Avoid loops with zero length

[ewan colsell]

in 1.10 beta 1 it's verry east to make loops with a legnth of zero, that is, the loop start and loop end are the same position.

this makes no sense, as no sound is output.

mixxx should either refuse to start looping in such a case, or default to a 1bar loop

[ewan colsell (ewanuno)]

I've been thinking about this, perhaps the most intuitive thing to do
is detect zero(or verry verry short) loops and when they are detected
put the song in pause.
we still want very short loops to be possible though, it's a really
nice effect if used well.
just the silence is unwanted.

2011/12/4, RJ Ryan <email address hidden>:
> ** Changed in: mixxx
> Status: New => Confirmed
>
> ** Changed in: mixxx
> Importance: Undecided => Medium
>
> ** Changed in: mixxx
> Milestone: None => 1.10.0
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/890483
>
> Title:
> avoid loops with zero legnth
>
> Status in Mixxx:
> Confirmed
>
> Bug description:
> in 1.10 beta 1 it's verry east to make loops with a legnth of zero,
> that is, the loop start and loop end are the same position.
>
> this makes no sense, as no sound is output.
>
> mixxx should either refuse to start looping in such a case, or default
> to a 1bar loop
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/890483/+subscriptions
>

--
Inviato dal mio dispositivo mobile

http://www.ewancolsell.com/

[Sean M. Pappalardo (pegasus-renegadetech)]

Fixed in 1.10 r2985

[RJ Skerry-Ryan (rryan)]

Thanks Sean -- we also need to fix the double/halve loop buttons because you can still set the loop arbitrarily small with them. It would be best if the loop validation logic that the various different slots in LoopingController all performed on their own was one common function. c'est la vie.

[RJ Skerry-Ryan (rryan)]

Added fixes to the scale length.

[RJ Skerry-Ryan (rryan)]

Minor TODO is that the fix is based on samples, not seconds. We should pick the minimum loop length as a time length and calculate the # of samples that implies based on the sample rate.

[Sean M. Pappalardo (pegasus-renegadetech)]

My fix for the beatloop case uses the smallest defined beatloop (currently 1/16th beat) and in the absence of a Beats object, the smallest reasonably audible loop (~30 samples at all sample rates. The pitch is just different with differing rates.)

[RJ Skerry-Ryan (rryan)]

Yup, I was talking about the smallest audible size (30 samples). It should
be a smallest audible length in seconds instead of samples.

On Thu, Dec 15, 2011 at 4:53 PM, Sean M. Pappalardo <
<email address hidden>> wrote:

> My fix for the beatloop case uses the smallest defined beatloop
> (currently 1/16th beat) and in the absence of a Beats object, the
> smallest reasonably audible loop (~30 samples at all sample rates. The
> pitch is just different with differing rates.)
>
> --
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
> https://bugs.launchpad.net/bugs/890483
>
> Title:
> Avoid loops with zero length
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/890483/+subscriptions
>

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6114