Add service - without service name or service type still going through

Bug #890399 reported by Jenny Vo
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Medium
Yogeshwar

Bug Description

Attempt adding a service without service name which appears as a required field still able to add without complain.
example request:
POST http://localhost:35357/v2.0/OS-KSADM/services HTTP/1.1

Accept-Encoding: gzip,deflate

X-Auth-Token: 999888777666

Accept: application/json

Content-Type: application/xml

User-Agent: Jakarta Commons-HttpClient/3.1

Host: localhost:35357

Content-Length: 138

<v1:service description="test description" id="" name="" type="test" xmlns:v1="http://docs.openstack.org/identity/api/ext/OS-KSADM/v1.0"/>
response:
{"OS-KSADM:service": {
   "type": "test",
   "id": "8",
   "description": "test description"
}}

Revision history for this message
Yogeshwar (yogesh-srikrishnan) wrote :

Iam working on it.

Changed in keystone:
assignee: nobody → Yogeshwar (yogesh-srikrishnan)
Changed in keystone:
importance: Undecided → Low
Revision history for this message
Yogeshwar (yogesh-srikrishnan) wrote :

Code is incorrect allover the places.The empty is wrong.Attempting to fix as many and also add tests.

Changed in keystone:
importance: Low → Medium
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/1721
Committed: http://github.com/openstack/keystone/commit/f6aa23c444dce6637a127905812810073c9930cb
Submitter: Jenkins
Branch: master

 status fixcommitted
 done

commit f6aa23c444dce6637a127905812810073c9930cb
Author: Yogeshwar Srikrishnan <email address hidden>
Date: Thu Nov 17 10:39:29 2011 -0600

    Bug #890399

    - Made create service calls to fail when there is no service name.
    - Along the way fixed incorrect equality checks for a string for various other calls.
    - Added tests to other api calls that were also failing
    - Made ==None checks to is None checks

    Change-Id: I2fa30442c60667b793ebca30efd9f79253fc740e

Changed in keystone:
status: New → Fix Committed
Changed in keystone:
milestone: none → essex-2
Thierry Carrez (ttx)
Changed in keystone:
status: Fix Committed → Fix Released
Revision history for this message
Jenny Vo (jenny-vo) wrote :

Test - Fixed

Thierry Carrez (ttx)
Changed in keystone:
milestone: essex-2 → 2012.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.