Mercurial tab completion doesn't work with files with spaces

Bug #889344 reported by Stephen Rasku
16
This bug affects 3 people
Affects Status Importance Assigned to Milestone
hg
Fix Released
Unknown
mercurial (Ubuntu)
Fix Released
Low
Vibhav Pant

Bug Description

If you use tab completion for a file with a space in it the tab completion doesn't escape the spaces or wrap the filename in quotes. This causes the filename to not be recognized.

To reproduce:

$ touch "x y z"
$ hg add x<Tab>y z
x: No such file or directory
y: No such file or directory
z: No such file or directory
$ ls x<Tab>\ y\ z
x y z

Related branches

Revision history for this message
Stephen Rasku (ubuntu-srasku) wrote :

$ hg version
Mercurial Distributed SCM (version 2.0)
(see http://mercurial.selenic.com for more information)

Copyright (C) 2005-2011 Matt Mackall and others
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Javi Merino (cibervicho)
Changed in mercurial (Ubuntu):
status: New → Confirmed
Changed in hg:
status: Unknown → New
Changed in hg:
status: New → Fix Released
Revision history for this message
Javi Merino (cibervicho) wrote :

Fixed in mercurial 2.1-1, available in debian.

Revision history for this message
Vibhav Pant (vibhavp) wrote :

Attached debdiff

Changed in mercurial (Ubuntu):
status: Confirmed → In Progress
importance: Undecided → Low
assignee: nobody → Andrew Starr-Bochicchio (andrewsomething)
Revision history for this message
Andrew Starr-Bochicchio (andrewsomething) wrote :

Hi Vibhav,

Thanks for your work on this. I just sponsored the upload.

FYI: I did make one small tweak. I removed some of the fields you put in the patch's header. There's no need to include stuff like Build Depends, Section, Uploaders, etc... We try to follow the guidelines laid out in DEP3 for patch headers. See: http://dep.debian.net/deps/dep3/

Thanks again!

Changed in mercurial (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package mercurial - 2.0.2-1ubuntu1

---------------
mercurial (2.0.2-1ubuntu1) precise; urgency=low

  * debian/bash_completion_with_spaces.patch
    - Mercurial bash completion will work with spaces (LP: #889344)
 -- Vibhav Pant <email address hidden> Tue, 27 Mar 2012 15:32:19 -0400

Changed in mercurial (Ubuntu):
status: Fix Committed → Fix Released
Vibhav Pant (vibhavp)
Changed in mercurial (Ubuntu):
assignee: Andrew Starr-Bochicchio (andrewsomething) → Vibhav Pant (vibhavp)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.