FFC

exterior facet integrals with coordinates fails for intervalls

Bug #888682 reported by Johan Hake
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
FFC
Fix Released
High
Kristian B. Ølgaard

Bug Description

This dolfin sample code triggers the bug:

from dolfin import *
mesh = UnitInterval(2)
V = FunctionSpace(mesh, "CG", 1)
f = Function(V)

# This works
assemble(interval.x*f*dx)

# This does not
assemble(interval.x*f*ds)

Johan Hake (johan-hake)
Changed in ffc:
milestone: none → 1.0-rc
importance: Undecided → High
Revision history for this message
Anders Logg (logg) wrote :

Looks like a problem in remove_unused

Revision history for this message
Kristian B. Ølgaard (k.b.oelgaard) wrote : Re: [Bug 888682] Re: exterior facet integrals with coordinates fails for intervalls

On 28 November 2011 14:16, Anders Logg <email address hidden> wrote:
> Looks like a problem in remove_unused

I think it is a problem with the 'used' set passed to remove_unused,
I'll take a look unless you almost got it.

Kristian

> --
> You received this bug notification because you are a member of FFC Core
> Team, which is subscribed to FFC.
> https://bugs.launchpad.net/bugs/888682
>
> Title:
>  exterior facet integrals with coordinates fails for intervalls
>
> Status in FEniCS Form Compiler:
>  New
>
> Bug description:
>  This dolfin sample code triggers the bug:
>
>  from dolfin import *
>  mesh = UnitInterval(2)
>  V = FunctionSpace(mesh, "CG", 1)
>  f = Function(V)
>
>  # This works
>  assemble(interval.x*f*dx)
>
>  # This does not
>  assemble(interval.x*f*ds)
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/ffc/+bug/888682/+subscriptions
>

Revision history for this message
Anders Logg (logg) wrote :

It looks like "x" is missing in the input to remove_unused on line 167 in quadraturegenerator.py:

  common = [remove_unused(jacobi_code, trans_set)]

It only happens to work with *dx since "x" is then also used in the top portion of the code, whereas in the *ds case, it is only
used below inside the quadrature code so it gets removed.

Kristian, could you look at this?

Changed in ffc:
assignee: nobody → Kristian B. Ølgaard (k.b.oelgaard)
status: New → Confirmed
Changed in ffc:
status: Confirmed → Fix Committed
Revision history for this message
Anders Logg (logg) wrote :

Thanks!

On Mon, Nov 28, 2011 at 02:19:16PM -0000, Kristian B. Ølgaard wrote:
> ** Changed in: ffc
> Status: Confirmed => Fix Committed
>

Anders Logg (logg)
Changed in ffc:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.