New Python solve interface badly broken

[Garth Wells]

New solve interface for variational problem has a serious bug. The code

    solve(a == L, Uh, bcs=bcs)

does not work. Culprit looks like

    # Extract boundary conditions
    if len(args) == 2:
        bcs = []
    else:
        bcs = _extract_bcs(args[2])

in solving.py.

[Anders Logg (logg)]

Looks like confusion about whether bcs should be a keyword argument or
not. Should we support both this

  solve(a == L, Uh, bcs=bcs)

and this

  solve(a == L, Uh, bcs)

?

--
Anders

On Wed, Nov 09, 2011 at 08:52:56PM -0000, Launchpad Bug Tracker wrote:
> Garth Wells (garth-wells) has assigned this bug to you for DOLFIN:
>
> New solve interface for variational problem has a serious bug. The code
>
> solve(a == L, Uh, bcs=bcs)
>
> does not work. Culprit looks like
>
> # Extract boundary conditions
> if len(args) == 2:
> bcs = []
> else:
> bcs = _extract_bcs(args[2])
>
> in solving.py.
>
> ** Affects: dolfin
> Importance: Critical
> Assignee: Anders Logg (logg)
> Status: New

[Johan Hake (johan-hake)]

On Wednesday November 9 2011 13:10:27 Anders Logg wrote:
> Looks like confusion about whether bcs should be a keyword argument or
> not. Should we support both this
>
> solve(a == L, Uh, bcs=bcs)
>
> and this
>
> solve(a == L, Uh, bcs)

I think only one of them. If one tries the other one it should raise an error.
I would prefer to go with the last option.

Johan

> ?
>
> --
> Anders
>
> On Wed, Nov 09, 2011 at 08:52:56PM -0000, Launchpad Bug Tracker wrote:
> > Garth Wells (garth-wells) has assigned this bug to you for DOLFIN:
> >
> > New solve interface for variational problem has a serious bug. The code
> >
> > solve(a == L, Uh, bcs=bcs)
> >
> > does not work. Culprit looks like
> >
> > # Extract boundary conditions
> >
> > if len(args) == 2:
> > bcs = []
> >
> > else:
> > bcs = _extract_bcs(args[2])
> >
> > in solving.py.
> >
> > ** Affects: dolfin
> >
> > Importance: Critical
> > Assignee: Anders Logg (logg)
> >
> > Status: New

[Garth Wells (garth-wells)]

On 9 November 2011 21:10, Anders Logg <email address hidden> wrote:
> Looks like confusion about whether bcs should be a keyword argument or
> not. Should we support both this
>
>  solve(a == L, Uh, bcs=bcs)
>

The docstring says that the above works, but it doesn't

Garth

> and this
>
>  solve(a == L, Uh, bcs)
>
> ?
>
> --
> Anders
>
>
> On Wed, Nov 09, 2011 at 08:52:56PM -0000, Launchpad Bug Tracker wrote:
>> Garth Wells (garth-wells) has assigned this bug to you for DOLFIN:
>>
>> New solve interface for variational problem has a serious bug. The code
>>
>>     solve(a == L, Uh, bcs=bcs)
>>
>> does not work. Culprit looks like
>>
>>     # Extract boundary conditions
>>     if len(args) == 2:
>>         bcs = []
>>     else:
>>         bcs = _extract_bcs(args[2])
>>
>> in solving.py.
>>
>> ** Affects: dolfin
>>      Importance: Critical
>>      Assignee: Anders Logg (logg)
>>          Status: New
>
> --
> You received this bug notification because you are a member of DOLFIN
> Core Team, which is subscribed to DOLFIN.
> https://bugs.launchpad.net/bugs/888282
>
> Title:
>  New Python solve interface badly broken
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/dolfin/+bug/888282/+subscriptions
>

[Anders Logg (logg)]

On Wed, Nov 09, 2011 at 09:25:15PM -0000, Garth Wells wrote:
> On 9 November 2011 21:10, Anders Logg <email address hidden> wrote:
> > Looks like confusion about whether bcs should be a keyword argument or
> > not. Should we support both this
> >
> >  solve(a == L, Uh, bcs=bcs)
> >
>
> The docstring says that the above works, but it doesn't

I know, but the question is which one should we use?

I looked now and the book claims that both work so then we need to
stick to that. I'll fix it as soon as I've merged my stuff into 1.0.

--
Anders

> Garth
>
> > and this
> >
> >  solve(a == L, Uh, bcs)
> >
> > ?
> >
> >
> >
> > On Wed, Nov 09, 2011 at 08:52:56PM -0000, Launchpad Bug Tracker wrote:
> >> Garth Wells (garth-wells) has assigned this bug to you for DOLFIN:
> >>
> >> New solve interface for variational problem has a serious bug. The code
> >>
> >>     solve(a == L, Uh, bcs=bcs)
> >>
> >> does not work. Culprit looks like
> >>
> >>     # Extract boundary conditions
> >>     if len(args) == 2:
> >>         bcs = []
> >>     else:
> >>         bcs = _extract_bcs(args[2])
> >>
> >> in solving.py.
> >>
> >> ** Affects: dolfin
> >>      Importance: Critical
> >>      Assignee: Anders Logg (logg)
> >>          Status: New
> >
> >
> > Title:
> >  New Python solve interface badly broken
> >
> > To manage notifications about this bug go to:
> > https://bugs.launchpad.net/dolfin/+bug/888282/+subscriptions
> >
>