After undo, selected areas do not have resize handles

[grofaty]

On Pinta 1.1 using PPA on Ubuntu 11.10:
1. Draw something on canvas to easly reproduce sample.
2. Rectangle Select and mark some area.
3. Click "Crop to Selection" from toolbar. Notice the blue selection squares that remains visible on picture? (See attached picture).
4. Save the picture clicking Save on toolbar like test.png.
5. Now close the image and open it again with Pinta and you will see this blue squares remains on picture.

The work around to get remove of this blue squares is:
4. Just click on Move Selected Pixels and blue squares disappear.

[grofaty (grofaty)]

I have also tested the same procedure on Pinta 1.0 and the problem does not appear. It looks like a Pinta 1.1 regression. It is somehow logical that this is v1.1 problem, because blue squares to resize image were added at Pinta 1.1.

[grofaty (grofaty)]

I have one more way to reproduce the same issue:
1. Open some image (or new image).
2. Rectangle Select and mark some area on canvas.
3. Click Undo from toolbar and blue squares remains visible on canvas.
If now picture is saved this blue squares remains in image.

P.S. The same problem with Ellipse Select object.

[Cameron White (cameronwhite91)]

I agree, this looks like an issue with the selection resizing feature from Pinta 1.1.

[grofaty (grofaty)]

I have found out third way to reproduce this issue:
1. Rectangle Select and mark some area on canvas.
2. Click on Deselect All button on toolbar.
If now picture is saved this blue squares remains in image.

[Robert Nordan (rpvn)]

I found the easiest way to reproduce: open a new image, select a square and press save without deselecting or changing tools, and the blue squares will be saved. It seems there are a lot of cases where the deactivation method is not called. The workaround is of course still to select a different tool so that the selection tool is deactivated.

[Robert Nordan (rpvn)]

Fixed in master by adding a handler for OnCommit (which is called before saves, crops etc) that clears the nodes like a deactivation.

https://github.com/PintaProject/Pinta/commit/8a32e4df2970f04b9c686ee791094e759e3cf4a9

[grofaty (grofaty)]

This fix is excellent main problem disappeared. Thanks for fixing this. But now one new problem appears (tested the latest development on Ubuntu 11.10). Rectangle select, crop and undo. When undo is made there is no more blue squares available to reselect selection. I make undo a lot, so when something does not look good after a crop I like to undo and change selection.

[Robert Nordan (rpvn)]

Updated the title to reflect the new bug. This one's not quite as bad, so it gets a lower priority.

[Cameron White (cameronwhite91)]

Bumping this in priority, as it's been annoying me recently.

[grofaty (grofaty)]

I can reproduce the problem like in #8 in Pinta v1.4 on Windows XP.

[Cameron White (cameronwhite91)]

A similar issue that I encountered (latest development version, including the fix for bug #990350):

1) Rectangle Select and mark some area.
2) Select another area (should be two selections in the history now).
3) Undo

The selection markers for the first selection aren't restored properly - the selection markers for the second selection are shown instead.

[Cameron White (cameronwhite91)]

I'm going to delay this until 1.6. I think it'll take some work to correctly fix, and I don't want to make significant changes close to a release.

[Cameron White (cameronwhite91)]

Fixed: https://github.com/PintaProject/Pinta/commit/09135832b1d3178be37af62cb738231549a42a2b