./run_tests.sh throws an error on keystone.test.functional.test_client.TestAdminClient

[Justin Shepherd]

 ./run_tests.sh
--SNIP--
Starting the RAX-KEY extension
Starting the Legacy Authentication component
Service API listening on 0.0.0.0:5000
Admin API listening on 0.0.0.0:35357
Running tests...
Stopping the keystone server...
Traceback (most recent call last):
  File "run_tests.py", line 31, in <module>
    test_cls().run()
  File "~/Projects/git/keystone/keystone/test/__init__.py", line 107, in run
    (BASE_DIR, TEST_DIR))
  File "~/Projects/git/keystone/keystone/test/__init__.py", line 44, in execute
    raise RuntimeError(msg)
RuntimeError: Command unit2 discover -f -t ~/Projects/git/keystone -s ~/Projects/git/keystone/keystone/test did not succeed. Returned an exit code of 1.

STDOUT:

STDERR: ............................E
======================================================================
ERROR: test_admin_get_token_bad_auth (keystone.test.functional.test_client.TestAdminClient)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "~/Projects/git/keystone/keystone/test/functional/test_client.py", line 61, in test_admin_get_token_bad_auth
    with self.assertRaises(keystone.common.exception.ClientError):
TypeError: failUnlessRaises() takes at least 3 arguments (2 given)

----------------------------------------------------------------------
Ran 29 tests in 13.794s

FAILED (errors=1)

[Justin Shepherd (jshepher)]

There are actually 2 issues in test/functional/test_client.py:

======================================================================
ERROR: test_admin_get_token_bad_auth (keystone.test.functional.test_client.TestServiceClient)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/justinshepherd/Projects/git/keystone/keystone/test/functional/test_client.py", line 87, in test_admin_get_token_bad_auth
    with self.assertRaises(keystone.common.exception.ClientError):
TypeError: failUnlessRaises() takes at least 3 arguments (2 given)

----------------------------------------------------------------------
Ran 33 tests in 13.516s

FAILED (errors=1)

[Justin Shepherd (jshepher)]

https://review.openstack.org/#change,1262

[Dolph Mathews (dolph)]

What version of Python are you seeing this exception on?

[Justin Shepherd (jshepher)]

$ uname -a
Darwin sideswipe 10.8.0 Darwin Kernel Version 10.8.0: Tue Jun 7 16:33:36 PDT 2011; root:xnu-1504.15.3~1/RELEASE_I386 i386

$python -V
Python 2.6.1

[Justin Shepherd (jshepher)]

Looks like the with block works in python 2.7.2

However the proposed fix works for both versions.

[Openstack Gerrit (openstack-gerrit)]

Reviewed: https://review.openstack.org/1262
Committed: http://github.com/openstack/keystone/commit/68c0f1c4ab18608c0705593f38646e287b68171e
Submitter: Jenkins
Branch: master

 status fixcommitted
 done

commit 68c0f1c4ab18608c0705593f38646e287b68171e
Author: Justin Shepherd <email address hidden>
Date: Wed Nov 2 13:38:56 2011 -0500

    bug 885364

    fixed 2 errors in self.assertRaises calls

    Change-Id: Ic31347348b6e4e5b769d2e09fe3a11f95642e824