assert_compute_node_has_enough_memory should check memory_mb is None or not

Bug #884842 reported by Nachi Ueno
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Davanum Srinivas (DIMS)
OpenStack Quality Assurance
Fix Released
Medium
Unassigned

Bug Description

This method always return True when the memory_mb is None.
https://github.com/openstack/nova/blob/master/nova/scheduler/driver.py#L380
This method should check memory_mb value.

assert_compute_node_has_enough_disk has same problem.

Nachi Ueno (nati-ueno)
Changed in openstack-qa:
assignee: nobody → Nachi Ueno (nati-ueno)
status: New → Confirmed
importance: Undecided → Medium
Thierry Carrez (ttx)
Changed in nova:
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
Nachi Ueno (nati-ueno) wrote :
tags: added: forward-port-needed
Nachi Ueno (nati-ueno)
Changed in openstack-qa:
assignee: Nachi Ueno (nati-ueno) → nobody
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/14806

Changed in nova:
assignee: nobody → Davanum Srinivas (dims-v)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/14806
Committed: http://github.com/openstack/nova/commit/27a5753dd3766b5535e0248d48c9bb555379dd12
Submitter: Jenkins
Branch: master

commit 27a5753dd3766b5535e0248d48c9bb555379dd12
Author: Davanum Srinivas <email address hidden>
Date: Wed Oct 24 21:56:49 2012 -0400

    Fix check for memory_mb

    assert_compute_node_has_enough_memory should check memory_mb is None or not

    _assert_dest_node_has_enough_disk should check available_mb as well

    Fixes bug 884842

    Change-Id: Ieaa33efd50bb84f1b475c437b26af1302fdfd19f

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → grizzly-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: grizzly-1 → 2013.1
Nachi Ueno (nati-ueno)
Changed in openstack-qa:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.