Problem with v1 theme with non-english characters in the name

[Carsten Tinggaard]

Windows 7, 64 bit, Home Premium and Vista Home Premium
OpenLP 1.9.7

Importing a v1 theme with non-english characters in the name results in three times of this dialog:
Error
File is not a valid theme
The content encoding is not UTF-8

and one time of this dialog:
Validation Error:
File is not a valid theme

This defect is related to Windows only since non-english characters in filenames are allowed from Win95 and onwards.

Attached example theme

[Andreas Preikschat (googol-deactivatedaccount)]

Thank you for reporting this. I was able to reproduce this.

[Meinert Jordan (m2j)]

Some days ago I've had a look into this. The basic problem is, that the file names in zip-files have no defined encoding.
We could use chardet, but it is not relyable for such short strings (even though wrong detection does not need to cause problems).

My approach would be to ignore the filenames and derive new filenames from the string stored in the theme XML.
This would works fine for now. As soon we want to store multiple files of the one type in the same theme it is not trivial anymore to assign the data to the generated filenames.

To be future proove we either have to restrict the filenames of additional files inside a theme or use the proposed solution only for 1.x themes while expecting filenames in 2.x themes being utf8 encoded.

Which one of these options should we prefere?

[Carsten Tinggaard (catini)]

I would prefer the approach to ignore the filename and derive filename from the string inside the theme XML - and restrict this way only for 1.x themes

[Meinert Jordan (m2j)]

The fix wouldn't work system independent