Listen should build-dep in firefox-dev

Bug #87959 reported by Emilio Pozuelo Monfort
2
Affects Status Importance Assigned to Milestone
Listen
Fix Released
Unknown
listen (Ubuntu)
Fix Released
Medium
Emilio Pozuelo Monfort

Bug Description

Binary package hint: listen

Listen currently does not build-depends on firefox-dev, so in the Makefile, when it does:

GTKMOZEMBED_PATH = $(shell pkg-config --libs-only-L mozilla-gtkmozembed 2>/dev/null || pkg-config --libs-only-L firefox-gtkmozembed 2>/dev/null | sed -e "s/-L//g" -e "s/[ ]/\,/" -e "s/[ ]//g" )

it doesn't work, and the gtkmozembed path isn't set up.

So adding firefox-dev, this should be fixed, and the patches 04_gtkmozembed.patch and 05_listen_bin.patch shouldn't be necessary.

Those patches were added to fix a segmentation fault when going to the lyrics or to the wikipedia info (Bug #86744).

Related branches

Changed in listen:
assignee: nobody → pochu
importance: Undecided → Low
status: Unconfirmed → In Progress
Revision history for this message
Emilio Pozuelo Monfort (pochu) wrote :

Currently, the makefile fails in Ubuntu.

I've created a patch, which is in the upstream bugtracker, which fixes the makefile.
With that patch applied, I'll be able to fix this bug.

Changed in listen:
importance: Low → Medium
Revision history for this message
Emilio Pozuelo Monfort (pochu) wrote :

Thanks Emmet for the sponsorship!

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sat, 19 May 2007 13:31:40 +0200
Source: listen
Binary: listen
Architecture: source
Version: 0.5-0ubuntu4
Distribution: gutsy
Urgency: low
Maintainer: Ubuntu MOTU Developers <email address hidden>
Changed-By: Emilio Pozuelo Monfort <email address hidden>
Description:
 listen - A nice music player and manager for GNOME
Launchpad-Bugs-Fixed: 87959 105001
Changes:
 listen (0.5-0ubuntu4) gutsy; urgency=low
 .
   * debian/patches:
     - Added 06_from_svn_mmkeys.patch (LP: #105001)
     - Added 04_makefile_works.patch (LP: #87959)
       + Removed 04_gtkmozembed.patch and 05_listen_bin.patch (not needed
         anymore, due to 04_makefile_works.patch)
     - Added 07_listen.py.patch (fixes lintian errors)
   * debian/control:
     - Added missing dependency on python-glade2 and firefox
     - Build-depend on firefox-dev instead of firefox
   * debian/rules:
     - Don't modify listen.py's hashbang (it's not there anymore because of
       07_listen.py.patch)
Files:
 9c1638fed74274e7971895b9e7c01a77 935 sound optional listen_0.5-0ubuntu4.dsc
 1b3da997ac266d4f273ba8a2380d2ef1 10500 sound optional listen_0.5-0ubuntu4.diff.
gz
Original-Maintainer: Julien Valroff <email address hidden>

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFGTwFh58vd3QD9QFcRAu/DAKC8VeKzHYmRZPATC/3PJZo635yBTgCfWVcG
+ZjGe9gXp5NeKwXBCj+XvEY=
=zd8N
-----END PGP SIGNATURE-----

Changed in listen:
status: In Progress → Fix Committed
Changed in listen:
status: Fix Committed → Fix Released
Revision history for this message
Emilio Pozuelo Monfort (pochu) wrote :

listen (0.5-3ubuntu1) gutsy; urgency=low

  * Merge with Debian (LP: #118030), remaining Ubuntu changes:
    - debian/patches:
      + Added 07_makefile_works, so we have a good LD_LIBRARY_PATH (LP: #87959)
    - debian/control:
      + Build-depend on firefox-dev instead of iceweasel
      + Depend on firefox
      + Do not depend on python-elementtree, since it's included in python2.5
      + Updated Maintainer field to match Debian-Maintainer-Spec

listen (0.5-3) unstable; urgency=low

  * Added notification-daemon as runtime dependency (Closes: #425877)

listen (0.5-2) unstable; urgency=low

  * Upload to unstable
  * Fixed dependency on python-glade2 (Emilio Pozuelo Monfort)
  * Applied patch from SVN to fix the multimedia keys
    (Emilio Pozuelo Monfort)

listen (0.5-1) experimental; urgency=low

  * New upstream release (Closes: #386448):
    + Improved GUI (Closes: #384947)
    + Added support for m4a/aac files with appropriate Gstreamer plugins
      (Closes: #384525)
  * Most changes to Debian packaging stolen from Ubuntu
    (thanks to Emilio Pozuelo Monfort <email address hidden>)
  * debian/rules
    + Fixed listen.png path (changed in upstream)
    + Removed /mutagen/_sanity.sh line, as it no longer exist
    + Removed dh_python call
  * debian/control
    + Changed short description to make it more neutral
    + Improved long description to better describe Listen features
    + Changed homepage url
    + Added python-mutagen (>= 1.8) to build-dependencies
    + Added intltool to both deps and build-deps
    + Added python-gnome2-dev, python-gnome2-extras-dev, iceweasel, sgml-data
      and python-gst0.10 to build-deps
    + Added libgail-dev and at-spi to build-deps to add accessibility support
    + Added dep to python-elementtree
    + Dropped dep on versioned python-pyvorbis
    + Recommends python-musicbrainz2 for optional AudioCD support
  * debian/patches/
    + 20_notification_area_restore.patch dropped (fixed upstream)
    + 15_desktop.patch dropped (useless)
    + 10_fix_exception.patch dropped (fixed upstream)
    + 05_remove_shebangs.patch dropped (fixed upstream)
    + 00_Makefile.patch dropped (some fixed, some useless)
    + 01_images_dir.patch dropped (useless)
    + 01_desktop_entry.patch added (fixes typos in .desktop file)
    + 02_utf-8.patch added (fixes 'Non-ASCII character warnings)
    + 03_fixed_dbus.patch added (fixes DBus call for dbus >= 0.80)
    + 04_skip_depchecks.patch added (skips dependecies checks while
      building the package)
    + 05_fix_shebang.patch added (removes useless shebang line in listen.py)
  * debian/copyright
    + Changed download url
    + Updated copyright (included 2007)
  * debian/README.Debian
    + Created to add a note about Libtunepimp support not active

 -- Emilio Pozuelo Monfort <email address hidden> Wed, 30 May 2007 17:56:49 +0200

Changed in listen:
status: Unknown → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.