Change hwpack field env_dd to take an offset

[Mattias Backman]

We should change the hwpack env_dd field to take a dd offset instead of Yes/No to be consistent with the other *_dd fields. The field is only used for Samsung boards.

This is also an opportunity to remove the Samsung specific hwpack V2 fields.

[Mattias Backman (mabac)]

We can do this in 2011.11

[James Westby (james-w)]

On Thu, 20 Oct 2011 06:49:21 -0000, Mattias Backman <email address hidden> wrote:
> Public bug reported:
>
> We should change the hwpack env_dd field to take a dd offset instead of
> Yes/No to be consistent with the other *_dd fields. The field is only
> used for Samsung boards.
>
> This is also an opportunity to remove the Samsung specific hwpack V2
> fields.

Does that imply a format bump so that old clients won't do the wrong
thing with the new information?

Thanks,

James

[Angus Ainslie (angus-akkea)]

On Thu, Oct 20, 2011 at 6:57 AM, James Westby <email address hidden> wrote:
> On Thu, 20 Oct 2011 06:49:21 -0000, Mattias Backman <email address hidden> wrote:
>> Public bug reported:
>>
>> We should change the hwpack env_dd field to take a dd offset instead of
>> Yes/No to be consistent with the other *_dd fields. The field is only
>> used for Samsung boards.
>>
>> This is also an opportunity to remove the Samsung specific hwpack V2
>> fields.
>
> Does that imply a format bump so that old clients won't do the wrong
> thing with the new information?
>

Right now the env_dd is specific for Samsung boards and I never
enabled it. From my point of view I don't see then need for a version
bump.

Angus

> Thanks,
>
> James
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/878681
>
> Title:
>  Change hwpack field env_dd to take an offset
>
> Status in Linaro Image Tools:
>  Confirmed
>
> Bug description:
>  We should change the hwpack env_dd field to take a dd offset instead
>  of Yes/No to be consistent with the other *_dd fields. The field is
>  only used for Samsung boards.
>
>  This is also an opportunity to remove the Samsung specific hwpack V2
>  fields.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/linaro-image-tools/+bug/878681/+subscriptions
>

--
Angus Ainslie <email address hidden>
Team Lead, Samsung Landing Team

[Mattias Backman (mabac)]

On Thu, Oct 20, 2011 at 3:35 PM, Angus Ainslie <email address hidden> wrote:
> On Thu, Oct 20, 2011 at 6:57 AM, James Westby <email address hidden> wrote:
>> On Thu, 20 Oct 2011 06:49:21 -0000, Mattias Backman <email address hidden> wrote:
>>> Public bug reported:
>>>
>>> We should change the hwpack env_dd field to take a dd offset instead of
>>> Yes/No to be consistent with the other *_dd fields. The field is only
>>> used for Samsung boards.
>>>
>>> This is also an opportunity to remove the Samsung specific hwpack V2
>>> fields.
>>
>> Does that imply a format bump so that old clients won't do the wrong
>> thing with the new information?
>>
>
> Right now the env_dd is specific for Samsung boards and I never
> enabled it. From my point of view I don't see then need for a version
> bump.

We would end up with hwpacks that contain information that won't work
with l-m-c 2011.09 and 2011.10 even though they support format version
2.0. So to make that clear we need to bump the format version, I
think. That way the old client will refuse to handle the hwpacks with
the unsupported format version instead of just failing.

The boards which do not use the env_dd and Samsung_* fields can still
use the 2.0 format, only the Samsung hwpacks need to use 2.1. We do
need to document which fields require which format version.

>
> Angus
>
>> Thanks,
>>
>> James
>>
>> --
>> You received this bug notification because you are subscribed to the bug
>> report.
>> https://bugs.launchpad.net/bugs/878681
>>
>> Title:
>>  Change hwpack field env_dd to take an offset
>>
>> Status in Linaro Image Tools:
>>  Confirmed
>>
>> Bug description:
>>  We should change the hwpack env_dd field to take a dd offset instead
>>  of Yes/No to be consistent with the other *_dd fields. The field is
>>  only used for Samsung boards.
>>
>>  This is also an opportunity to remove the Samsung specific hwpack V2
>>  fields.
>>
>> To manage notifications about this bug go to:
>> https://bugs.launchpad.net/linaro-image-tools/+bug/878681/+subscriptions
>>
>
>
> --
> Angus Ainslie <email address hidden>
> Team Lead, Samsung Landing Team
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/878681
>
> Title:
>  Change hwpack field env_dd to take an offset
>
> Status in Linaro Image Tools:
>  Confirmed
>
> Bug description:
>  We should change the hwpack env_dd field to take a dd offset instead
>  of Yes/No to be consistent with the other *_dd fields. The field is
>  only used for Samsung boards.
>
>  This is also an opportunity to remove the Samsung specific hwpack V2
>  fields.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/linaro-image-tools/+bug/878681/+subscriptions
>

[James Westby (james-w)]

On Thu, 20 Oct 2011 13:35:56 -0000, Angus Ainslie <email address hidden> wrote:
> Right now the env_dd is specific for Samsung boards and I never
> enabled it. From my point of view I don't see then need for a version
> bump.

Right, but the code is out there that is expecting to get Yes/No for
that field, so changing the meaning will break that code.

Thanks,

James

[Milo Casagrande (milo)]

Due to the age of this issue, we are acknowledging that this issue will likely not be fixed, is no longer applicable, or was already fixed by an indirect change. If this issue is still important, please add details and reopen the issue using http://bugs.linaro.org.