Launcher - Quicklist's "Quit" item removal is confusing
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ayatana Design |
Fix Committed
|
Low
|
John Lea | ||
Unity |
Fix Released
|
Low
|
Marco Trevisan (Treviño) | ||
unity (Ubuntu) |
Fix Released
|
Low
|
Marco Trevisan (Treviño) |
Bug Description
At the moment, if an application sets a quicklist menu and in that menu an item has a name that matches _("Quit"), we automatically remove our own Quit item from the standard actions section, so the menu looks like:
-------
| Refresh
-------
| Send
-------
| Quit
-------
| Gwibber Social Client
-------
| [x] Keep In Launcher
-------
The problem with this is, when you go to quit the application, it jarring that the option has moved.
Proposed solution 1: we should hide their Quit action, but relay clicking on our Quit-item to their Quick-item's action. So we don't move the Quit button but they get to do whatever it is they want to do before quitting.
Proposed solution 2: We just hide their quit, as we don't want to change what our Quit does
It is proposed that we proceed with 'solution 2' on the basis that this approach will cause the least issues.
Related branches
- PS Jenkins bot (community): Approve (continuous-integration)
- Christopher Townsend (community): Approve
-
Diff: 473 lines (+238/-63)8 files modifiedlauncher/ApplicationLauncherIcon.cpp (+38/-57)
launcher/ApplicationLauncherIcon.h (+1/-1)
launcher/LauncherIcon.cpp (+18/-2)
launcher/LauncherIcon.h (+3/-2)
launcher/QuicklistMenuItem.cpp (+1/-0)
launcher/QuicklistMenuItem.h (+1/-0)
tests/data/applications/ubuntu-software-center.desktop (+11/-0)
tests/test_application_launcher_icon.cpp (+165/-1)
Changed in unity: | |
status: | New → Incomplete |
Changed in ayatana-design: | |
assignee: | nobody → John Lea (johnlea) |
description: | updated |
Changed in ayatana-design: | |
importance: | Undecided → Low |
status: | New → Fix Committed |
Changed in unity: | |
status: | Incomplete → Confirmed |
Changed in unity (Ubuntu): | |
status: | New → Confirmed |
tags: | added: udo |
tags: | added: udp |
Changed in unity: | |
milestone: | none → backlog |
Changed in ayatana-design: | |
status: | Fix Committed → Triaged |
tags: | added: quicklist |
Changed in ayatana-design: | |
status: | Triaged → Fix Committed |
Changed in unity: | |
assignee: | Mirco Müller (macslow) → Marco Trevisan (Treviño) (3v1n0) |
importance: | Undecided → Low |
Changed in unity (Ubuntu): | |
importance: | Undecided → Low |
Changed in unity: | |
milestone: | backlog → none |
Changed in unity: | |
status: | Confirmed → Triaged |
Changed in unity (Ubuntu): | |
status: | Confirmed → Triaged |
summary: |
- Quicklist's "Quit" item removal is confusing + Launcher - Quicklist's "Quit" item removal is confusing |
Changed in unity (Ubuntu): | |
status: | Triaged → In Progress |
Changed in unity: | |
status: | Triaged → In Progress |
milestone: | none → 7.1.0 |
Changed in unity (Ubuntu): | |
assignee: | nobody → Marco Trevisan (Treviño) (3v1n0) |
Fix committed into lp:unity at revision None, scheduled for release in unity, milestone 7.1.0