Check disc for defects failed with a iso images built using ubuntu-defaults-image

Bug #873401 reported by Jun Kobayashi
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
casper (Ubuntu)
Fix Released
Low
Colin Watson
Oneiric
Fix Released
Low
Colin Watson

Bug Description

I built a iso image with ubuntu-defaults-image to make Ubuntu Japanese Remix distribution, and it works fine.
But I selected "Check disk for defects" in isolinux menu, that reports "errors found in 3 files!".

Version of Ubuntu: 11.10
Version of ubuntu-defaults-builder: 0.23
Version of live-build: 3.0~a24-1ubuntu17

Revision history for this message
Jun Kobayashi (jkbys) wrote :

I found following 3 non checksum lines at the front of md5sum.txt.

--
This file contains the list of md5 checksums of all files on this medium.

You can verify them automatically with the 'integrity-check' boot parameter,
or, manually with: 'md5sum -c md5sum.txt'.
--

These lines may cause the error message.

David Planella (dpm)
affects: live-build (Ubuntu) → ubuntu-defaults-builder (Ubuntu)
Martin Pitt (pitti)
Changed in ubuntu-defaults-builder (Ubuntu):
status: New → In Progress
importance: Undecided → Low
assignee: nobody → Martin Pitt (pitti)
Revision history for this message
Martin Pitt (pitti) wrote :

Unfortunately I can't fix this in ubuntu-defaults-image with a hook:

$ cat config/binary_local-hooks/clean-md5sum
#!/bin/sh -e
sed -in '/^[0-9a-f]\{32\} / p' binary/md5sum.txt

"lb binary_checksums" is called after "lb binary_local-hooks", so at the time when the hook runs we don't have the md5sums file yet.

I see two solutions:

  - remove the code in live-build's scripts/build/lb_binary_checksums which prepends that header
  - Fix the md5sum check component of gfxboot to ignore the header

affects: ubuntu-defaults-builder (Ubuntu) → live-build (Ubuntu)
Changed in live-build (Ubuntu):
assignee: Martin Pitt (pitti) → nobody
status: In Progress → Triaged
Revision history for this message
Colin Watson (cjwatson) wrote :

We should fix this in casper, which implements the check.

affects: live-build (Ubuntu) → casper (Ubuntu)
Changed in casper (Ubuntu):
assignee: nobody → Colin Watson (cjwatson)
Changed in casper (Ubuntu Oneiric):
status: New → Triaged
importance: Undecided → Low
assignee: nobody → Colin Watson (cjwatson)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package casper - 1.288

---------------
casper (1.288) precise; urgency=low

  * Ignore lines in md5sum.txt that aren't md5sum output (LP: #873401).
 -- Colin Watson <email address hidden> Mon, 24 Oct 2011 17:05:55 +0100

Changed in casper (Ubuntu):
status: Triaged → Fix Released
Colin Watson (cjwatson)
Changed in casper (Ubuntu Oneiric):
status: Triaged → In Progress
Revision history for this message
Martin Pitt (pitti) wrote : Please test proposed package

Hello Jun, or anyone else affected,

Accepted casper into oneiric-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Changed in casper (Ubuntu Oneiric):
status: In Progress → Fix Committed
tags: added: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package casper - 1.287.1

---------------
casper (1.287.1) oneiric-proposed; urgency=low

  * Ignore lines in md5sum.txt that aren't md5sum output (LP: #873401).
  * Canonicalise debian-installer/locale= / locale= into a UTF-8 locale when
    processing preseeding, in line with how we set up the locale in the live
    environment (LP: #882308).
 -- Colin Watson <email address hidden> Tue, 08 Nov 2011 15:48:36 +0000

Changed in casper (Ubuntu Oneiric):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.