Resuming a failed upload crashes with ValueError: I/O operation on closed file
Affects | Status | Importance | Assigned to | Milestone | ||
---|---|---|---|---|---|---|
Ubuntu One Client | Status tracked in Trunk | |||||
Stable-2-0 |
Fix Released
|
Critical
|
Natalia Bidart | |||
Trunk |
Fix Released
|
Critical
|
Natalia Bidart | |||
ubuntuone-client (Ubuntu) |
Fix Released
|
Critical
|
Ubuntu One Client Engineering team | |||
Oneiric |
Fix Released
|
Critical
|
Ubuntu One Client Engineering team | |||
Precise |
Fix Released
|
Critical
|
Ubuntu One Client Engineering team |
Bug Description
Resuming a failed upload crashes with ValueError: I/O operation on closed file. After this this particular upload is dropped and syncdaemon believes it is synchronized (IDLE)
TEST CASE:
1. Grab a file of substantial size (100Mb is ok) which is not yet on Ubuntu One
2. Put it to ~/Ubuntu One folder
3. Wait until upload starts by looking at u1sdtool --current-transfers
4. Simulate server disconnect/network issue by shutting down network.
5. SD will enter READY state, upload is still queued
6. Connect to network again
Expected results:
SD starts to upload the remaining part of the file
Actual results:
Upload fails completely - AQ_UPLOAD_ERROR, syncdaemon returns to IDLE state. File is not uploaded to personal storage.
2011-10-12 18:08:52,408 - ubuntuone.
Traceback (most recent call last):
File "/usr/lib/
result = yield self.running_
ValueError: I/O operation on closed file
2011-10-12 18:08:52,428 - ubuntuone.
2011-10-12 18:08:52,428 - ubuntuone.
2011-10-12 18:08:52,789 - ubuntuone.
2011-10-12 18:08:52,790 - ubuntuone.
2011-10-12 18:08:52,793 - ubuntuone.
2011-10-12 18:08:52,794 - ubuntuone.
2011-10-12 18:08:52,797 - ubuntuone.
2011-10-12 18:08:52,798 - ubuntuone.
2011-10-12 18:08:52,803 - ubuntuone.
ProblemType: Bug
DistroRelease: Ubuntu 11.10
Package: ubuntuone-client 2.0.0-0ubuntu2
ProcVersionSign
Uname: Linux 3.0.0-12-generic x86_64
NonfreeKernelMo
ApportVersion: 1.23-0ubuntu3
Architecture: amd64
Date: Wed Oct 12 18:14:12 2011
EcryptfsInUse: Yes
InstallationMedia: Ubuntu 10.04 LTS "Lucid Lynx" - Release amd64 (20100429)
PackageArchitec
SourcePackage: ubuntuone-client
UpgradeStatus: Upgraded to oneiric on 2011-08-30 (43 days ago)
Related branches
- Roman Yepishev (community): Approve (fieldtest)
- Facundo Batista (community): Approve
-
Diff: 124 lines (+28/-25)2 files modifiedtests/syncdaemon/test_action_queue.py (+21/-5)
ubuntuone/syncdaemon/action_queue.py (+7/-20)
- Facundo Batista (community): Approve
- Joshua Hoover (community): Approve (tested)
-
Diff: 946 lines (+165/-87)14 files modifiedtests/platform/linux/eventlog/test_zglog.py (+3/-2)
tests/platform/linux/test_dbus.py (+2/-1)
tests/platform/linux/test_messaging.py (+1/-9)
tests/platform/linux/test_notification.py (+1/-9)
tests/platform/linux/test_unity.py (+3/-0)
tests/platform/linux/test_vm.py (+6/-2)
tests/platform/test_interaction_interfaces.py (+18/-8)
tests/status/test_aggregator.py (+20/-2)
tests/syncdaemon/test_action_queue.py (+58/-13)
tests/syncdaemon/test_logger.py (+11/-0)
tests/syncdaemon/test_pathlockingtree.py (+8/-0)
tests/syncdaemon/test_states.py (+16/-5)
tests/syncdaemon/test_status_listener.py (+2/-1)
ubuntuone/syncdaemon/action_queue.py (+16/-35)
- Ubuntu One hackers: Pending requested
-
Diff: 2080 lines (+1928/-0) (has conflicts)4 files modifiedtests/platform/linux/test_dbus.py (+1685/-0)
tests/platform/linux/test_notification.py (+7/-0)
tests/status/test_aggregator.py (+5/-0)
tests/syncdaemon/test_interaction_interfaces.py (+231/-0)
Changed in ubuntuone-client: | |
status: | New → Confirmed |
importance: | Undecided → High |
Changed in ubuntuone-client (Ubuntu): | |
importance: | Undecided → High |
tags: | added: chicharra chicharra-oneiric |
tags: | added: u1-oneiric-sru |
Changed in ubuntuone-client (Ubuntu): | |
status: | Confirmed → New |
Changed in ubuntuone-client (Ubuntu): | |
milestone: | none → oneiric-updates |
Changed in ubuntuone-client (Ubuntu): | |
status: | New → Confirmed |
tags: | added: support |
Changed in ubuntuone-client: | |
importance: | High → Critical |
Changed in ubuntuone-client: | |
status: | Confirmed → Triaged |
assignee: | nobody → Natalia Bidart (nataliabidart) |
Changed in ubuntuone-client: | |
status: | Triaged → Fix Committed |
description: | updated |
Changed in ubuntuone-client (Ubuntu): | |
importance: | High → Critical |
assignee: | nobody → Ubuntu One Desktop+ team (ubuntuone-desktop+) |
Changed in ubuntuone-client (Ubuntu Oneiric): | |
milestone: | none → oneiric-updates |
Changed in ubuntuone-client (Ubuntu Precise): | |
milestone: | oneiric-updates → precise-alpha-1 |
Changed in ubuntuone-client (Ubuntu Oneiric): | |
assignee: | nobody → Ubuntu One Desktop+ team (ubuntuone-desktop+) |
importance: | Undecided → Critical |
tags: |
added: verification-done removed: verification-needed |
Changed in ubuntuone-client: | |
status: | Fix Committed → Fix Released |
tags: | removed: u1-oneiric-sru |
Status changed to 'Confirmed' because the bug affects multiple users.