Stock Internal Moves

Bug #871675 reported by Mohammed

This bug report was converted into a question: question #174025: Stock Internal Moves.

6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Odoo Addons (MOVED TO GITHUB)
Invalid
Undecided
Unassigned

Bug Description

I am asking from is journal entries while doing internal move between internal stock locations, where I see openerp is not satisfying and it is missing and I can assure that from this part of code where entries got generated :

""" # Outgoing moves (or cross-company output part)
            if move.location_id.company_id \
                and (move.location_id.usage == 'internal' and move.location_dest_id.usage != 'internal'\
                     or move.location_id.company_id != move.location_dest_id.company_id):
                journal_id, acc_src, acc_dest, acc_variation = self._get_accounting_data_for_valuation(cr, uid, move, src_company_ctx)
                reference_amount, reference_currency_id = self._get_reference_accounting_values_for_valuation(cr, uid, move, src_company_ctx)
                account_moves += [(journal_id, self._create_account_move_line(cr, uid, move, acc_variation, acc_dest, reference_amount, reference_currency_id, context))]

            # Incoming moves (or cross-company input part)
            if move.location_dest_id.company_id \
                and (move.location_id.usage != 'internal' and move.location_dest_id.usage == 'internal'\
                     or move.location_id.company_id != move.location_dest_id.company_id):
                journal_id, acc_src, acc_dest, acc_variation = self._get_accounting_data_for_valuation(cr, uid, move, dest_company_ctx)
                reference_amount, reference_currency_id = self._get_reference_accounting_values_for_valuation(cr, uid, move, src_company_ctx)
                account_moves += [(journal_id, self._create_account_move_line(cr, uid, move, acc_src, acc_variation, reference_amount, reference_currency_id, context))]"""

Having said that, I see openerp just generate entries from incoming and outgoing moves and don't for internal moves where

move.location_id.usage == 'internal' and move.location_dest_id.usage == 'internal'

For example when doing internal move from stock_a to stock_b (both are internal locations), it should generate a journal entry stock_a credit and stock_b debit with the amount of product moved

Revision history for this message
Amit Parik (amit-parik) wrote :

Hello Mohammad,

I have checked your issue but I am not agree with you.

The stock accounting entires are created only when we are insert or send a stock to our stock location. It means that when we have purchase or sale a product then and only then stock account 's journal entires will be created.

In simple word when your source location is "Supplier" or destination location is "Customer" then it will be generated.

From your issue you have described a "Internal move" means you have internally transfer a stock form one location to another.
When these stock comes in your stock_a location from source location to "supplier" then it's journal entries was created.
Now you have transfer the stock from stock_a to stock_b is at these time if again journal entries will generated then two times same entires will created which is not correct.

So this is the functional behaviour not a bug, that's why I am closing this issue.

Correct me If I am wrong.

Thanks.

Changed in openobject-addons:
status: New → Invalid
Revision history for this message
Mohammed (gaafer5) wrote : Re: [Bug 871675] Re: Stock Internal Moves
Download full text (4.1 KiB)

Hello Amit,

This issue maybe raised, because we are following different approach. Here I am going to tell you about our chart of account and correct me if I am wrong. We have individual account for each stock location under current asset parent account.

Is that right configuration and is it comply with Openerp stocks accounting methodology.

Thanks in advance,

Mohammed

--- On Wed, 10/12/11, Amit Parik (OpenERP) <email address hidden> wrote:

From: Amit Parik (OpenERP) <email address hidden>
Subject: [Bug 871675] Re: Stock Internal Moves
To: <email address hidden>
Date: Wednesday, October 12, 2011, 5:51 AM

Hello Mohammad,

I have checked your issue but I am not agree with you.

The stock accounting entires are created only when we are insert or send
a stock to our stock location. It means that when we have purchase or
sale a product then and only then stock account 's journal entires will
be created.

In simple word when your source location is "Supplier" or destination
location is "Customer" then it will be generated.

>From your issue you have described a "Internal move" means you have internally transfer a  stock form one location to another.
When these stock comes in your stock_a location from source location to "supplier" then it's journal entries was created.
Now you have transfer the stock  from stock_a to stock_b is at these time if again journal entries will generated then two times same entires will created which is not correct.

So this is the functional behaviour not a bug, that's why I am closing
this issue.

Correct me If I am wrong.

Thanks.

** Changed in: openobject-addons
       Status: New => Invalid

** Converted to question:
   https://answers.launchpad.net/openobject-addons/+question/174025

--
You received this bug notification because you are subscribed to the bug
report.
https://bugs.launchpad.net/bugs/871675

Title:
  Stock Internal Moves

Status in OpenERP Addons (modules):
  Invalid

Bug description:
  I am asking from is journal entries while doing internal move between
  internal stock locations, where I see openerp is not satisfying and it
  is missing and I can assure that from this part of code where entries
  got generated :

  """ # Outgoing moves (or cross-company output part)
              if move.location_id.company_id \
                  and (move.location_id.usage == 'internal' and move.location_dest_id.usage != 'internal'\
                       or move.location_id.company_id != move.location_dest_id.company_id):
                  journal_id, acc_src, acc_dest, acc_variation = self._get_accounting_data_for_valuation(cr, uid, move, src_company_ctx)
                  reference_amount, reference_currency_id = self._get_reference_accounting_values_for_valuation(cr, uid, move, src_company_ctx)
                  account_moves += [(journal_id, self._create_account_move_line(cr, uid, move, acc_variation, acc_dest, reference_amount, reference_currency_id, context))]

              # Incoming moves (or cross-company input part)
              if move.location_dest_id.company_id \
                  and (move.location_id.usage != 'internal' and move.location_dest_id.usage == 'internal'\
                       or move.locatio...

Read more...

Revision history for this message
Amit Parik (amit-parik) wrote :

Hello Mohammad,

I am not agree with you, because you have described that you have set a individual account for each stock location in comment#2.
And in your bug description you have specified that your stock location are internal location.

So there creating some confusion here, because we can give a stock input A/c and stock o/p A/c for individual stock location when either our location type is "Production" or "Inventory".

We can not give a individual stock account for each stock location if our location type is "Internal".

So would you please change your location type and then try again.

Thanks your your reply!

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Related questions

Remote bug watches

Bug watches keep track of this bug in other bug trackers.