_sql_constraints and _constraints exceptions open an application error window

Bug #869936 reported by Thibaut DIRLIK (Logica)
54
This bug affects 6 people
Affects Status Importance Assigned to Milestone
Odoo Server (MOVED TO GITHUB)
Fix Released
Medium
OpenERP's Framework R&D

Bug Description

Constraints errors defined in models' _sql_constraints opens an exception window (with stracktrace, etc) wheras it should opens a simple dialog showing the message error. In latest trunk.

Related branches

Revision history for this message
Vo Minh Thu (thu) wrote :

Exception handling, to pass them from server to client has changed. It seems the work has been done correctly for XMLRPC but not for NETRPC.

affects: openobject-client → openobject-server
Changed in openobject-server:
status: New → Confirmed
Revision history for this message
Thibaut DIRLIK (Logica) (thibaut-dirlik) wrote : Re: [Bug 869936] Re: _sql_constraints exception opens an exception window

Indeed, I've the correct message with XMLRPC.

2011/10/7 Vo Minh Thu (OpenERP) <email address hidden>

> Exception handling, to pass them from server to client has changed. It
> seems the work has been done correctly for XMLRPC but not for NETRPC.
>
> ** Project changed: openobject-client => openobject-server
>
> ** Changed in: openobject-server
> Status: New => Confirmed
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/869936
>
> Title:
> _sql_constraints exception opens an exception window
>
> Status in OpenERP Server:
> Confirmed
>
> Bug description:
> Constraints errors defined in models' _sql_constraints opens an
> exception window (with stracktrace, etc) wheras it should opens a
> simple dialog showing the message error. In latest trunk.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/openobject-server/+bug/869936/+subscriptions
>

Revision history for this message
Amit Parik (amit-parik) wrote : Re: _sql_constraints exception opens an exception window

Hello,

I am agree with Vo Minh Thu. The exception window is only open of r net-rpc for xml-rpc it works fine.

Thanks.

Changed in openobject-server:
assignee: nobody → OpenERP's Framework R&D (openerp-dev-framework)
importance: Undecided → Medium
Revision history for this message
Numérigraphe (numerigraphe) wrote :

As reported in Bug #893078, this affects constraints too when the error message is from a method.
LS.

summary: - _sql_constraints exception opens an exception window
+ _sql_constraints and _constraints exceptions open an application error
+ window
Revision history for this message
Thibaut DIRLIK (Logica) (thibaut-dirlik) wrote :

Is this going to be fixed soon? Any clue on how to fix it? I'm ready to work on this.

Revision history for this message
Vo Minh Thu (thu) wrote :

Thibaut,

Thanks a lot for proposing your help on this.

You simply have to look at the exception handling going on around the call to netsvc.dispatch_rpc() in the openerp/wsgi.py file, and replicate it in the exception handling (again around netsvc.dispatch_rpc()) in openerp/service/netrpc_server.py.

Revision history for this message
Naresh(OpenERP) (nch-openerp) wrote :

Hi Thibaut DIRLIK,

any updates on this ?

Regards,

Revision history for this message
Naresh(OpenERP) (nch-openerp) wrote :

Hello,

Thanks for reporting !
It has been fixed at lp:openerp-dev/openobject-server/trunk-bug-869936-nch with revision-info: 3877 <email address hidden> and will be merged soon to the trunk server.

Regards,

Changed in openobject-server:
status: Confirmed → In Progress
status: In Progress → Fix Committed
Revision history for this message
Thibaut DIRLIK (Logica) (thibaut-dirlik) wrote : Re: [Bug 869936] Re: _sql_constraints and _constraints exceptions open an application error window

Thanks for your work on this !

2011/12/15 Naresh(OpenERP) <email address hidden>

> Hello,
>
> Thanks for reporting !
> It has been fixed at lp:openerp-dev/openobject-server/trunk-bug-869936-nch
> with revision-info: 3877 <email address hidden> will be merged soon to the trunk server.
>
>
> Regards,
>
> ** Changed in: openobject-server
> Status: In Progress => Fix Committed
>
> --
> You received this bug notification because you are a member of OpenERP
> Committers, which is subscribed to OpenERP Server.
> https://bugs.launchpad.net/bugs/869936
>
> Title:
> _sql_constraints and _constraints exceptions open an application error
> window
>
> Status in OpenERP Server:
> Fix Committed
>
> Bug description:
> Constraints errors defined in models' _sql_constraints opens an
> exception window (with stracktrace, etc) wheras it should opens a
> simple dialog showing the message error. In latest trunk.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/openobject-server/+bug/869936/+subscriptions
>

Revision history for this message
Vo Minh Thu (thu) wrote :

Fix landed in trunk:
revno: 3910
revision-id: <email address hidden>

Thanks for the bug report!

Changed in openobject-server:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.