Missing accept form for some users on pending friends list
Bug #861888 reported by
Richard Mansfield
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mahara |
Fix Released
|
Low
|
Richard Mansfield |
Bug Description
The query to get user data on the my friends and find friends pages has an unnecessary union, with one select to get pending friends, and another to get everyone else.
The result of this is that pending friends are sometimes not shown as pending if their record was returned by both parts of the query, and so the logged-in user sometimes can't accept requests on these pages.
Changed in mahara: | |
status: | New → In Progress |
importance: | Undecided → Low |
assignee: | nobody → Richard Mansfield (richard-mansfield) |
milestone: | none → 1.5.0 |
Changed in mahara: | |
status: | In Progress → Fix Committed |
To post a comment you must log in.
Reviewed: https:/ /reviews. mahara. org/749 gitorious. org/mahara/ mahara/ commit/ 43d739ebaea0727 8d5d3bc22ceb9bf a50130e411
Committed: http://
Submitter: Richard Mansfield (<email address hidden>)
Branch: master
commit 43d739ebaea0727 8d5d3bc22ceb9bf a50130e411
Author: Richard Mansfield <email address hidden>
Date: Thu Sep 29 11:25:31 2011 +1300
Simplify query to get user data for find/my friends (bug #861888)
The query to get user data on the my friends and find friends pages
has an unnecessary union, with one select to get pending friends, and
another to get everyone else.
The result of this is that pending friends are sometimes not shown as
pending if their record was returned by both parts of the query, and
so the logged-in user sometimes can't accept requests on these pages.
Change-Id: I31347d680988f9 4d9329abb5c2338 c0c8c285b00
Signed-off-by: Richard Mansfield <email address hidden>