Maildisabled preference not respected in activity notifications
Bug #860090 reported by
Richard Mansfield
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mahara |
Fix Released
|
Medium
|
Richard Mansfield |
Bug Description
Commit a8102e9129 tried to fetch all users' maildisabled preferences in the activity_get_users function, but failed because it used the wrong table alias, so maildisabled is not being respected by the email_user function whenever email_user is called by an activity notification (which is most of the time).
Changed in mahara: | |
status: | New → In Progress |
importance: | Undecided → Medium |
assignee: | nobody → Richard Mansfield (richard-mansfield) |
milestone: | none → 1.4.1 |
Changed in mahara: | |
status: | In Progress → Fix Committed |
Changed in mahara: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Reviewed: https:/ /reviews. mahara. org/743 gitorious. org/mahara/ mahara/ commit/ 91d8620545bb33c ed4fd094e913ecc f57fdf886a
Committed: http://
Submitter: Richard Mansfield (<email address hidden>)
Branch: master
commit 91d8620545bb33c ed4fd094e913ecc f57fdf886a
Author: Richard Mansfield <email address hidden>
Date: Tue Sep 27 11:03:22 2011 +1300
Fix maildisbled preference in activity_get_users (bug #860090)
Commit a8102e9129 tried to fetch all users' maildisabled preferences
in the activity_get_users function, but failed because it used the
wrong table alias, so maildisabled is not being respected by the
email_user function whenever email_user is called by an activity
notification (most of the time).
Change-Id: I2a9cf1afa3f866 1ff8a52f1ce5aed 5d15adaa9da
Signed-off-by: Richard Mansfield <email address hidden>