xfce4-indicator-plugin does not update output

Bug #852017 reported by Stefan Lithén
38
This bug affects 6 people
Affects Status Importance Assigned to Milestone
xfce4
Unknown
Unknown
xfce4-indicator-plugin (Ubuntu)
Fix Released
Medium
Lionel Le Folgoc
Oneiric
Fix Released
High
Unassigned
Precise
Fix Released
Medium
Lionel Le Folgoc

Bug Description

I'm trying to use indicator-sysmonitor in xubuntu 11.10 and it does not refresh the output text from the indicator.
It works great in xubuntu 11.04 and also in both ubuntu 11.04 and 11.10 so it seems the problem is in the xfce4-indicator-plugin for xubuntu 11.10.

(The indicator-sysmonitor is a simple indicator that outputs text/sysinfo in interval)

Revision history for this message
Jason Conti (jconti) wrote :

Looking at entry_added in panel-plugin/indicator.c, the indicator button's label is only set when the entry is initially added. Attaching a patch that watches for changes to the text of the entry's label and updates the button's label text.

Another option would be to use the button as a container and pack the image/label into a box instead of using the button's set_image and set_label methods.

Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in xfce4-indicator-plugin (Ubuntu):
status: New → Confirmed
Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "watch_label_changes.patch" of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-sponsors please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

tags: added: patch
Changed in xfce4-indicator-plugin (Ubuntu):
importance: Undecided → Medium
Revision history for this message
artjermyn (artjermyn) wrote :

The patch by Jason Conti works fine on my system.

Changed in xfce4-indicator-plugin (Ubuntu Oneiric):
status: New → Confirmed
importance: Undecided → High
Changed in xfce4-indicator-plugin (Ubuntu Oneiric):
status: Confirmed → Triaged
Changed in xfce4-indicator-plugin (Ubuntu Precise):
status: Confirmed → Triaged
Revision history for this message
Lionel Le Folgoc (mrpouit) wrote :

Patch committed upstream, will be part of xfce4-indicator-plugin 0.4.0 that should be released today (then, 0.4.0 will go into precise, and 0.3.1 + this patch to oneiric-updates).

Changed in xfce4-indicator-plugin (Ubuntu Precise):
status: Triaged → Fix Committed
Changed in xfce4-indicator-plugin (Ubuntu Oneiric):
status: Triaged → In Progress
assignee: nobody → Lionel Le Folgoc (mrpouit)
Changed in xfce4-indicator-plugin (Ubuntu Precise):
assignee: nobody → Lionel Le Folgoc (mrpouit)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package xfce4-indicator-plugin - 0.4.0-0ubuntu1

---------------
xfce4-indicator-plugin (0.4.0-0ubuntu1) precise; urgency=low

  * Upload pkg-xfce svn r6172 to precise, no remaining Ubuntu change:
    - debian/patches:
      + 03_attach-button-to-menu-right-at-the-beginning.patch,
        02_fix-menu-position.patch, 01_search-for-indicator-0.4-pc.patch,
        xubuntu_exclude-modules.patch: dropped, included upstream.
  * Bugs fixed by this new upstream release:
    - "Scrolling the mousewheel over the sound-indicator doesn't adjust the
      volume". lp: #879928
    - "xfce4-indicator-plugin does not update output". lp: #852017

xfce4-indicator-plugin (0.4.0-1) UNRELEASED; urgency=low

  [ Evgeni Golov ]
  * Switch Recommends to indicator-messages-gtk2, we cannot use
    the GTK3 version provided by indicator-messages.

  [ Lionel Le Folgoc ]
  * New upstream release.
  * debian/patches:
    - search-for-indicator-0.4-pc.patch, fix_menu_position.patch,
      attach_button_to_menu_right_at_the_beginning.patch: dropped, included
      upstream.
    - potfiles.patch: dropped, not needed anymore.
 -- Lionel Le Folgoc <email address hidden> Sun, 30 Oct 2011 18:50:42 +0100

Changed in xfce4-indicator-plugin (Ubuntu Precise):
status: Fix Committed → Fix Released
Revision history for this message
Lionel Le Folgoc (mrpouit) wrote :

Fixed in precise. The fix for oneiric is waiting for approval, and should be available for wider testing in a few days (you'll be able to test it as described on https://wiki.ubuntu.com/QATeam/PerformingSRUVerification and https://wiki.ubuntu.com/Testing/EnableProposed).

Changed in xfce4-indicator-plugin (Ubuntu Oneiric):
assignee: Lionel Le Folgoc (mrpouit) → nobody
status: In Progress → Fix Committed
Revision history for this message
Martin Pitt (pitti) wrote : Please test proposed package

Hello Stefan, or anyone else affected,

Accepted xfce4-indicator-plugin into oneiric-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

tags: added: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package xfce4-indicator-plugin - 0.3.1-1ubuntu3.1

---------------
xfce4-indicator-plugin (0.3.1-1ubuntu3.1) oneiric-proposed; urgency=low

  * debian/patches:
    - 04_watch-label-changes.patch: added missing callback to update text
      labels set by indicators (patch by Jason Conti, thanks!) lp: #852017
    - 05_readd-on-scroll-event.patch: updated signal name to relay mouse
      scrolls to indicators (e.g. indicator-sound). lp: #879928
    - series: enable these two patches.
 -- Lionel Le Folgoc <email address hidden> Sun, 30 Oct 2011 18:31:58 +0100

Changed in xfce4-indicator-plugin (Ubuntu Oneiric):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.