Diffs not available for syncs on +queue page like for regular uploads

[Scott Kitterman]

As you can see from the attached screen shot, we have diffs available on pages like https://launchpad.net/ubuntu/oneiric/+queue?queue_state=1 for regular uploads, but when syncs were added to this page, diffs for syncs weren't. Reviewing the diff for a proposed sync takes a non-trivial effort since you have to go pull the package from Debian and from Ubuntu, download them both, and then debdiff them. Please add this for syncs as well.

[Colin Watson (cjwatson)]

I've been looking at this a bit. Generating the diff in time is easy (actually easier than doing it in its current position, I think), but showing it is hard because diffs are linked to SPRs and PCJs don't have a fixed SPR.

I wonder if it would be terrible to just add an optional SPR reference to the PCJ table, so that we could use that to look up PackageDiffs as needed? We don't always have an SPR in hand (e.g. in DistroSeriesLocalDifferencesView.requestUpgrades), but as far as I can see the cases where we don't have one when creating the PCJ don't matter for queue reviews.

[Colin Watson (cjwatson)]

Discussion at the client sprint: we should encapsulate the SourcePackageRelease handling within PackageCopyJob rather than passing it in from sites that create the jobs; but since PCJs never end up in DistroSeries:+queue until they've been partially run and decided to suspend themselves, they could compute their own SPR links at that point. That would still require a new DB column.