Incorrect sequence of calculations in product/pricelist.py price_get_multi

[Graeme Gellatly]

Hi,

I just saw this and noted that it is rounded before calculations on price have finished meaning either the rounding is entirely unnecessary and hence a place where errors might come in, or it is happening too early. It should happen after the final price is determined. But also I think you want to look at that bit of code because it just looks wrong - if you use the min_margin or max_margin functionality (which I don't) surely this must be based off a cost price, yet it is calculated using the just fetched price by the looks of things.

                        if price is not False:
                            price_limit = price

                            price = price * (1.0+(res['price_discount'] or 0.0))
                            price = rounding(price, res['price_round'])
                            price += (res['price_surcharge'] or 0.0)
                            if res['price_min_margin']:
                                price = max(price, price_limit+res['price_min_margin'])
                            if res['price_max_margin']:
                                price = min(price, price_limit+res['price_max_margin'])
                            break

[Vishal Parmar(Open ERP) (vpa-openerp)]

Hello Graeme Gellatly,

Would you please elaborate more with proper example so I can reproduce the early rounding issue.

Thanks and waiting for your reply.

[Graeme Gellatly (gdgellatly)]

I've had a closer look, and it is very tricky and somewhat pointless to
worry about given the min and max margin is not really right. The current
order gives the right behaviour if min and max margin aren't used, and given
they are mostly unusable I'll set this as invalid.

On Tue, Sep 13, 2011 at 6:52 PM, Vishal Parmar(Open ERP) <
<email address hidden>> wrote:

> Hello Graeme Gellatly,
>
> Would you please elaborate more with proper example so I can reproduce
> the early rounding issue.
>
> Thanks and waiting for your reply.
>
> ** Changed in: openobject-addons
> Status: New => Incomplete
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/847609
>
> Title:
> Incorrect sequence of calculations in product/pricelist.py
> price_get_multi
>
> Status in OpenERP Addons (modules):
> Incomplete
>
> Bug description:
> Hi,
>
> I just saw this and noted that it is rounded before calculations on
> price have finished meaning either the rounding is entirely
> unnecessary and hence a place where errors might come in, or it is
> happening too early. It should happen after the final price is
> determined. But also I think you want to look at that bit of code
> because it just looks wrong - if you use the min_margin or max_margin
> functionality (which I don't) surely this must be based off a cost
> price, yet it is calculated using the just fetched price by the looks
> of things.
>
> if price is not False:
> price_limit = price
>
> price = price * (1.0+(res['price_discount'] or
> 0.0))
> price = rounding(price, res['price_round'])
> price += (res['price_surcharge'] or 0.0)
> if res['price_min_margin']:
> price = max(price,
> price_limit+res['price_min_margin'])
> if res['price_max_margin']:
> price = min(price,
> price_limit+res['price_max_margin'])
> break
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/openobject-addons/+bug/847609/+subscriptions
>