Colors look inverted on the LCD in build 2 of stage-origen-11.09-release

[Zach Pfeffer]

In

https://android-build.linaro.org/builds/~linaro-android/stage-origen-11.09-release/#build=2

The colors come up inverted.

[Botao (botao-sun)]

What do you mean "inverted"? I take a screen shot of 11.09 build 2, refer to attachment.

[Angus Ainslie (angus-akkea)]

It looks kind of like a BGR RGB encoding problem

On Fri, Sep 9, 2011 at 8:33 PM, Botao Sun <email address hidden> wrote:
> What do you mean "inverted"? I take a screen shot of 11.09 build 2,
> refer to attachment.
>
> ** Attachment added: "11.09 build 2 screen shot"
>   https://bugs.launchpad.net/linaro-android/+bug/845793/+attachment/2379931/+files/11.09_Build_2_Screen_Shot.jpg
>
> --
> You received this bug notification because you are a member of Linaro
> Landing Team: Samsung, which is subscribed to linaro-landing-team-
> samsung.
> https://bugs.launchpad.net/bugs/845793
>
> Title:
>  Colors look inverted on the LCD in build 2 of stage-
>  origen-11.09-release
>
> Status in Linaro Android:
>  New
> Status in Linaro Samsung Landing Team Project:
>  New
>
> Bug description:
>  In
>
>  https://android-build.linaro.org/builds/~linaro-android/stage-
>  origen-11.09-release/#build=2
>
>  The colors come up inverted.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/linaro-android/+bug/845793/+subscriptions
>

--
Angus Ainslie <email address hidden>
Team Lead, Samsung Landing Team

[Zach Pfeffer (pfefferz)]

Here's a shot of the correct colors.

[Angus Ainslie (angus-akkea)]

Thanks Zach

@Botao can you do a test with pure red, green and blue colours and see
if they are just mapped wrong ?

On Mon, Sep 12, 2011 at 9:48 AM, Zach Pfeffer <email address hidden> wrote:
> Here's a shot of the correct colors.
>
> ** Attachment added: "Panda_Showing_Correct_Colors.jpg"
>   https://bugs.launchpad.net/linaro-android/+bug/845793/+attachment/2391853/+files/Panda_Showing_Correct_Colors.jpg
>
> --
> You received this bug notification because you are a member of Linaro
> Landing Team: Samsung, which is subscribed to linaro-landing-team-
> samsung.
> https://bugs.launchpad.net/bugs/845793
>
> Title:
>  Colors look inverted on the LCD in build 2 of stage-
>  origen-11.09-release
>
> Status in Linaro Android:
>  New
> Status in Linaro Samsung Landing Team Project:
>  New
>
> Bug description:
>  In
>
>  https://android-build.linaro.org/builds/~linaro-android/stage-
>  origen-11.09-release/#build=2
>
>  The colors come up inverted.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/linaro-android/+bug/845793/+subscriptions
>

--
Angus Ainslie <email address hidden>
Team Lead, Samsung Landing Team

[Botao (botao-sun)]

The blue and red are inverted, refer to attachment.

[Botao (botao-sun)]

Vishal and I are working on this and we think we have a patch now:

In file hardware/libhardware/modules/gralloc/framebuffer.cpp, do the change as following:

@@ -355,7 +358,7 @@ int fb_device_open(hw_module_t const* module, const char* name,
         if (status >= 0) {
             int stride = m->finfo.line_length / (m->info.bits_per_pixel >> 3);
             int format = (m->info.bits_per_pixel == 32)
- ? HAL_PIXEL_FORMAT_RGBX_8888
+ ? HAL_PIXEL_FORMAT_BGRA_8888
                          : HAL_PIXEL_FORMAT_RGB_565;

I have tested it and the color has backed to normal.

This issue also exist in the Panda build as Vishal mentioned.

Attachment is that library file we generated, you can copy it to /system/lib/hw path of Origen build to make a test.

Also, Vishal found this bug: https://bugs.launchpad.net/linaro-android/+bug/803634