Don't trigger an upgrade when there's already one in progress

Bug #844480 reported by Richard Mansfield
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Low
Richard Mansfield

Bug Description

When an upgrade is in progress, and someone hits the admin/upgrade.php page, Mahara stupidly starts a second upgrade. The second upgrade usually fails, but we need to stop this from happening, because it could potentially result in inconsistencies.

Tags: upgrade
Changed in mahara:
status: New → In Progress
importance: Undecided → Low
assignee: nobody → Richard Mansfield (richard-mansfield)
milestone: none → 1.5.0
description: updated
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/635
Committed: http://gitorious.org/mahara/mahara/commit/b5713230f85e94398af158c07dcc6917214d6505
Submitter: Francois Marier (<email address hidden>)
Branch: master

commit b5713230f85e94398af158c07dcc6917214d6505
Author: Richard Mansfield <email address hidden>
Date: Fri Sep 2 15:38:41 2011 +1200

    Prevent multiple simultaneous upgrades (bug #844480)

    When an upgrade is running, prevent requests for admin/upgrade.php
    from immediately starting up a second unwanted upgrade by inserting
    a record in the config table. Nothing is done on fresh installs,
    because the config table won't exist.

    Change-Id: Ib82505d04fcb90b0ccbb461acd0d0b4646460498
    Signed-off-by: Richard Mansfield <email address hidden>

Changed in mahara:
status: In Progress → Fix Committed
tags: added: upgrade
Revision history for this message
Melissa Draper (melissa) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

 status fixreleased
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJPjqAJAAoJECXBtiziiXdchQQIAK/IGQeAExkYtvahfy2aQ9aH
ZukB7Pcqj6r08Oami8JinoHI4Hqt7zJX2ZzBix8Vd0y/IzcO8fPys5VuP/IxOrYo
V+67Kx9w5MZpCzdCZ0EXHZPGruA5WM9ox4GnyhMXyHDP40vuGTxknakTz0EWSeMt
cj2IFMUf4rdJhm0NQHZmlNKDiO8L+o6j9NbyXJOp9allJa9X70tX//GSixcaCADP
bSdLaddxX8uWSGjd0wnh0i6VteORKjrnoCZh7bmWu00xGHeuYDujcIDRByA+Rowr
1bmlho7wDKyU8SHZfX4uWeRWel8f5A7zx0F/FKpDJddz8WDIUkkiNAeLYPOuuq0=
=XTFY
-----END PGP SIGNATURE-----

Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.