Google spreadsheet can't be embedded

Bug #843588 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Melissa Draper

Bug Description

It seems like that Google spreadsheets can't be embedded anymore. I think to remember that it worked just a short while ago, but not anymore. Another user has remarked on this on the download page of the plugin for Mahara 1.3 as well (http://mahara.org/view/view.php?id=11634).

Changed in mahara:
milestone: none → 1.4.1
importance: Undecided → Medium
status: New → Triaged
Melissa Draper (melissa)
Changed in mahara:
assignee: nobody → Melissa Draper (melissa)
status: Triaged → Confirmed
Revision history for this message
Melissa Draper (melissa) wrote :

https://reviews.mahara.org/#change,674 has been pushed for this. Google needs to stop breaking our toys :P

Changed in mahara:
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/674
Committed: http://gitorious.org/mahara/mahara/commit/8fd516c100f3b470cacfbee3f4d5cf1505b7adc9
Submitter: Francois Marier (<email address hidden>)
Branch: master

commit 8fd516c100f3b470cacfbee3f4d5cf1505b7adc9
Author: Melissa Draper <email address hidden>
Date: Fri Sep 9 15:41:20 2011 +1200

    Add new docs filter for different spreadsheet url (bug #843588)

    It seems that the google spreadsheets published url changed and was
    not being caught by the existing regexs. This adds a new regex that
    catches the new format.

    Change-Id: Ic51ae17a789f2f97647796d9a4daa5d13d2d0108
    Signed-off-by: Melissa Draper <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/681
Committed: http://gitorious.org/mahara/mahara/commit/8c1316f372146535cbc242ce1f205ff0274f3378
Submitter: Francois Marier (<email address hidden>)
Branch: 1.4_STABLE

commit 8c1316f372146535cbc242ce1f205ff0274f3378
Author: Melissa Draper <email address hidden>
Date: Fri Sep 9 15:41:20 2011 +1200

    Add new docs filter for different spreadsheet url (bug #843588)

    It seems that the google spreadsheets published url changed and was
    not being caught by the existing regexs. This adds a new regex that
    catches the new format.

    Cherry-picked from 8fd516c100f3b470cacfbee3f4d5cf1505b7adc9

    Change-Id: Ic51ae17a789f2f97647796d9a4daa5d13d2d0108
    Signed-off-by: Melissa Draper <email address hidden>

Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

Sorry, but this needs to be re-opened as Google changed its spreadsheet URLs yet again. It's now https://docs.google.com/spreadsheet/ccc?key=0AuV_s9Ys157udGNXcF9uZ2NETHhWc2EyS1FDRElUS3c&hl=en_US

-> according to Melissa it's ccc instead of pub

Revision history for this message
François Marier (fmarier) wrote :
Changed in mahara:
status: Fix Committed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/709
Committed: http://gitorious.org/mahara/mahara/commit/2f9f7ac82ea640e46b51408533e3bde955f3902d
Submitter: Francois Marier (<email address hidden>)
Branch: master

commit 2f9f7ac82ea640e46b51408533e3bde955f3902d
Author: Melissa Draper <email address hidden>
Date: Mon Sep 19 17:14:35 2011 +1200

    Fix the spreadsheet filter again (bug #843588)

    This adds a new regex that catches the new format. Addendum
    to 8c1316f372146535cbc242ce1f205ff0274f3378 in which "id=" changed
    to "key=", this patch covers spreadsheets where google has now
    changed the url from "/pub." to "/ccc."

    Change-Id: Id2c013257ae801e251b8b8cd9fb1fcc10a7c933b
    Signed-off-by: Melissa Draper <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/710
Committed: http://gitorious.org/mahara/mahara/commit/efb2178304f581b3dae52b1285eeb4b1aa85c994
Submitter: Francois Marier (<email address hidden>)
Branch: 1.4_STABLE

commit efb2178304f581b3dae52b1285eeb4b1aa85c994
Author: Melissa Draper <email address hidden>
Date: Mon Sep 19 17:14:35 2011 +1200

    Fix the spreadsheet filter again (bug #843588)

    This adds a new regex that catches the new format. Addendum
    to 8c1316f372146535cbc242ce1f205ff0274f3378 in which "id=" changed
    to "key=", this patch covers spreadsheets where google has now
    changed the url from "/pub." to "/ccc."

    Change-Id: Id2c013257ae801e251b8b8cd9fb1fcc10a7c933b
    Signed-off-by: Melissa Draper <email address hidden>

Changed in mahara:
status: In Progress → Fix Committed
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.