Add wakeup support to adodb

Bug #841711 reported by Andrew Nicols
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Wishlist
Andrew Nicols

Bug Description

For phpunit testing, we need to reconnect to the database between unit tests because phpunit backs up and restores globals between tests.

Bit of a pain to deviate (once again) from the adodb distribution but this is only required for the unit tests so packaging (e.g. debian) can probably ignore this change and use stock adodb

Tags: adodb db phpunit
Changed in mahara:
status: New → In Progress
importance: Undecided → Wishlist
assignee: nobody → Andrew Nicols (dobedobedoh)
milestone: none → 1.5.0
Revision history for this message
Andrew Nicols (dobedobedoh) wrote :

Submitted penny's change for this with changes - added to adodb/README.mahara and removed debugging echos

https://reviews.mahara.org/640

Revision history for this message
François Marier (fmarier) wrote :

Note: the Debian package uses the bundled version of ADODB already for reasons I can't remember...

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/640
Committed: http://gitorious.org/mahara/mahara/commit/417077459037550239fe9b09bd20b50d4c19b57f
Submitter: Francois Marier (<email address hidden>)
Branch: master

commit 417077459037550239fe9b09bd20b50d4c19b57f
Author: Penny Leach <email address hidden>
Date: Sun Aug 23 14:54:23 2009 +0200

    Bug #841711: ADODB modification: add __wakeup to connection object

    This reconnects to the db after wakeup, as resource types cannot be
    serialized and unserialized.

    This is necessary for unit tests, phpunit backups and restore globals
    between each test.

    Change-Id: I160b4c68ac1db0c3c0a3e1aec1b0dc8584763bf9
    Signed-off-by: Penny Leach <email address hidden>
    Signed-off-by: Andrew Robert Nicols <email address hidden>

Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Melissa Draper (melissa) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

 status fixreleased
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJPjrYkAAoJECXBtiziiXdcBjUH+gOs1qGQ20HFISw5maAWKxaU
yT4JUSRYzcVk8g5FgnONKIDVMKo9ZiyZD0xTWoevwRamE5IiE00ltsoxtaVecvBx
Km/hOBIiaTCfNlZ/nCULO+FUflYWhuzjb8szGQNCLTJLXzHq1Q/BRJAWPzKvUweo
zKe23pNiXtMlRkqEs+IwWnf04M3YH8O6tqcoirtLWPmLRJxtW19qT5LOGdkFojVP
ode3BhogyPMFWxS9mhn0AgE9j/GdNMXbPxKCSqLhrcDCQvC+wXNqvWC/Fp7jMe0n
5mPXBmBPLCiQAIQ7a9GNV/71GhLEB6YkZ1HZj+EkCuXvdejKe/MutEVgHIiZUus=
=Yjja
-----END PGP SIGNATURE-----

Changed in mahara:
status: Fix Committed → Fix Released
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/3950

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/7529

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.