next libreoffice ftbfs (all archs)

[Matthias Klose]

fails in
ERROR: error 65280 occurred while making /build/buildd/libreoffice-3.4.2/libreoffice-build/build/libreoffice-3.4.2.3/connectivity/source/drivers/postgresql

/build/buildd/libreoffice-3.4.2/libreoffice-build/build/libreoffice-3.4.2.3/connectivity/source/drivers/postgresql/pq_resultsetmetadata.cxx:165:30: instantiated from here
/usr/include/c++/4.6/bits/stl_uninitialized.h:576:6: error: no matching function for call to 'pq_sdbc_driver::Allocator<pq_sdbc_driver::ColDesc>::construct(pq_sdbc_driver::ColDesc*)'
/usr/include/c++/4.6/bits/stl_uninitialized.h:576:6: note: candidate is:
/build/buildd/libreoffice-3.4.2/libreoffice-build/build/libreoffice-3.4.2.3/connectivity/source/drivers/postgresql/pq_allocator.hxx:173:10: note: void pq_sdbc_driver::Allocator<T>::construct(pq_sdbc_driver::Allocator<T>::pointer, const T&) [with T = pq_sdbc_driver::ColDesc, pq_sdbc_driver::Allocator<T>::pointer = pq_sdbc_driver::ColDesc*]
/build/buildd/libreoffice-3.4.2/libreoffice-build/build/libreoffice-3.4.2.3/connectivity/source/drivers/postgresql/pq_allocator.hxx:173:10: note: candidate expects 2 arguments, 1 provided
In file included from /build/buildd/libreoffice-3.4.2/libreoffice-build/build/libreoffice-3.4.2.3/connectivity/source/drivers/postgresql/pq_connection.hxx:88:0,
                 from /build/buildd/libreoffice-3.4.2/libreoffice-build/build/libreoffice-3.4.2.3/connectivity/source/drivers/postgresql/pq_resultsetmetadata.hxx:65,
                 from /build/buildd/libreoffice-3.4.2/libreoffice-build/build/libreoffice-3.4.2.3/connectivity/source/drivers/postgresql/pq_resultsetmetadata.cxx:63:
/build/buildd/libreoffice-3.4.2/libreoffice-build/build/libreoffice-3.4.2.3/connectivity/source/drivers/postgresql/pq_allocator.hxx: At global scope:
/build/buildd/libreoffice-3.4.2/libreoffice-build/build/libreoffice-3.4.2.3/connectivity/source/drivers/postgresql/pq_allocator.hxx: In instantiation of 'void pq_sdbc_driver::Allocator<T>::deallocate(pq_sdbc_driver::Allocator<T>::pointer, pq_sdbc_driver::Allocator<T>::size_type) [with T = pq_sdbc_driver::ColumnMetaData, pq_sdbc_driver::Allocator<T>::pointer = pq_sdbc_driver::ColumnMetaData*, pq_sdbc_driver::Allocator<T>::size_type = unsigned int]':
/usr/include/c++/4.6/bits/stl_vector.h:156:4: instantiated from 'void std::_Vector_base<_Tp, _Alloc>::_M_deallocate(typename _Alloc::rebind<_Tp>::other::pointer, std::size_t) [with _Tp = pq_sdbc_driver::ColumnMetaData, _Alloc = pq_sdbc_driver::Allocator<pq_sdbc_driver::ColumnMetaData>, typename _Alloc::rebind<_Tp>::other::pointer = pq_sdbc_driver::ColumnMetaData*, std::size_t = unsigned int]'
/usr/include/c++/4.6/bits/stl_vector.h:142:9: instantiated from 'std::_Vector_base<_Tp, _Alloc>::~_Vector_base() [with _Tp = pq_sdbc_driver::ColumnMetaData, _Alloc = pq_sdbc_driver::Allocator<pq_sdbc_driver::ColumnMetaData>]'
/usr/include/c++/4.6/bits/stl_vector.h:218:15: instantiated from 'std::vector<_Tp, _Alloc>::vector() [with _Tp = pq_sdbc_driver::ColumnMetaData, _Alloc = pq_sdbc_driver::Allocator<pq_sdbc_driver::ColumnMetaData>]'
/build/buildd/libreoffice-3.4.2/libreoffice-build/build/libreoffice-3.4.2.3/connectivity/source/drivers/postgresql/pq_statics.hxx:287:14: instantiated from here
/build/buildd/libreoffice-3.4.2/libreoffice-build/build/libreoffice-3.4.2.3/connectivity/source/drivers/postgresql/pq_allocator.hxx:167:10: warning: unused parameter 'n' [-Wunused-parameter]

[Martin Pitt (pitti)]

This seems to have collided with the postgresql 9.1 update from yesterday. libpq's API did not change that much, but if LibO is using some of the /usr/include/postgresql/internal/* headers, it might need some adaptions for

-extern char *first_path_separator(const char *pathlist);
+extern char *first_path_var_separator(const char *pathlist);

-extern int pg_get_encoding_from_locale(const char *ctype);
+extern int pg_get_encoding_from_locale(const char *ctype, bool write_message);

-extern int SetClientEncoding(int encoding, bool doit);
+extern int PrepareClientEncoding(int encoding);
+extern int SetClientEncoding(int encoding);

-extern void copydir(char *fromdir, char *todir, bool recurse);

These are the only API changes I can see.

[Martin Pitt (pitti)]

This is the full diff between the 9.0 and 9.1 libpq APIs, in case it helps.

[Launchpad Janitor (janitor)]

This bug was fixed in the package libreoffice - 1:3.4.2-2ubuntu2

---------------
libreoffice (1:3.4.2-2ubuntu2) oneiric; urgency=low

  * still keep sdbc_postgresql disabled for now (LP: #834178)
  * regenerate control
 -- Bjoern Michaelsen <email address hidden> Fri, 26 Aug 2011 10:21:03 +0200

[Launchpad Janitor (janitor)]

This bug was fixed in the package libreoffice-l10n - 1:3.4.2-2ubuntu2

---------------
libreoffice-l10n (1:3.4.2-2ubuntu2) oneiric; urgency=low

  * merge all changes up to 1:3.4.2-2ubuntu2
  * regenerate control

libreoffice (1:3.4.2-2ubuntu2) oneiric; urgency=low

  * still keep sdbc_postgresql disabled for now (LP: #834178)
  * regenerate control
 -- Bjoern Michaelsen <email address hidden> Fri, 26 Aug 2011 10:30:10 +0200