copyPackages() doesn't close LP bugs

[Stefano Rivera]

Native syncing doesn't close LP bugs that were closed in Debian's changelog.

[Julian Edwards (julian-edwards)]

Thanks for filing this, I'll sort it out soon.

[Julian Edwards (julian-edwards)]

Should this work on all change logs for versions between the last publication and the one being synced, or just the one being synced?

[Stefano Rivera (stefanor)]

I see Laney cleared this up on IRC, yes all versions since the last publication.

(This could mean that we miss versions: e.g. if we go from 1.0-1 to 2.0-0ubuntu1, then if we sync 2.0-1 we wouldn't get bug closing for the changelog entry from 1.0-2. But that's what would happen if someone did a manual sync/merge, so I think it's to be expected)

[Julian Edwards (julian-edwards)]

On Thursday 25 August 2011 16:53:21 you wrote:
> I see Laney cleared this up on IRC, yes all versions since the last
> publication.
>
> (This could mean that we miss versions: e.g. if we go from 1.0-1 to
> 2.0-0ubuntu1, then if we sync 2.0-1 we wouldn't get bug closing for the
> changelog entry from 1.0-2. But that's what would happen if someone did
> a manual sync/merge, so I think it's to be expected)

I'm not sure I follow that so I'll tell you what I am making it do and you can
check if it meets expectations.

Consider:
 * we have 1.0-1 in Ubuntu
 * Debian also has 1.0-2 and 1.0-3

If we sync 1.0-3 then bugs will be closed referenced in changelogs for 1.0-2
and 1.0-3.

Does that sound okay?

Thanks.

[Iain Lane (laney)]

Hi,

On Thu, Aug 25, 2011 at 04:05:41PM -0000, Julian Edwards wrote:
> On Thursday 25 August 2011 16:53:21 you wrote:
> > I see Laney cleared this up on IRC, yes all versions since the last
> > publication.
> >
> > (This could mean that we miss versions: e.g. if we go from 1.0-1 to
> > 2.0-0ubuntu1, then if we sync 2.0-1 we wouldn't get bug closing for the
> > changelog entry from 1.0-2. But that's what would happen if someone did
> > a manual sync/merge, so I think it's to be expected)
>
> I'm not sure I follow that so I'll tell you what I am making it do and you can
> check if it meets expectations.
>
> Consider:
> * we have 1.0-1 in Ubuntu
> * Debian also has 1.0-2 and 1.0-3
>
> If we sync 1.0-3 then bugs will be closed referenced in changelogs for 1.0-2
> and 1.0-3.
>
> Does that sound okay?

That is right. He's saying this

 * Ubuntu has 1.0-1
 * Debian uploads 1.0-2 which closes some LP bugs
 * Ubuntu then uploads a new version 2.0-0ubuntu1 without syncing 1.0-2
 * Debian uploads 2.0.0-1 which we sync

LP bugs closed in 1.0-2 are then not closed because we only consider the
changelog for versions greater than 2.0-0ubuntu1.

I don't think this is a problem. It's not a regression from what we have
now.

Cheers,

Iain

[Stefano Rivera (stefanor)]

> I'm not sure I follow that so I'll tell you what I am making it do and you can
> check if it meets expectations.
>
> Consider:
> * we have 1.0-1 in Ubuntu
> * Debian also has 1.0-2 and 1.0-3
>
> If we sync 1.0-3 then bugs will be closed referenced in changelogs for 1.0-2
> and 1.0-3.
>
> Does that sound okay?

Correct.

I was talking about:

Debian and us have 1.0-1
We jump to 2.0-0ubuntu1
Debian uploads 1.0-2, then 2.0-1
We sync 2.0-1.

The expected behavior is that we only get the changelog from 2.0-1

[William Grant (wgrant)]

Shouldn't we close all bugs since the base version, not the last publication in Ubuntu?

[Micah Gersten (micahg)]

I agree with William, but one's a regression and one isn't. If there isn't enough time to do this, would a follow up bug be helpful to track it?

[Stefano Rivera (stefanor)]

Probably. Although this may not be what people initially expect.

[Micah Gersten (micahg)]

If the Debian maintainer is going through the trouble of trying to close the Launchpad bug in the changelog, I think we should probably close it for them. Yes, this is currently not how it works, but I think that's actually a bug. It also currently prevents the changes done to the Debian package between the base version and the new version from showing up on *-changes where Ubuntu does a new upstream before Debian and Debian subsequently makes changes while it has the previous version.

[Iain Lane (laney)]

On Fri, Aug 26, 2011 at 07:20:34AM -0000, Micah Gersten wrote:
> If the Debian maintainer is going through the trouble of trying to close
> the Launchpad bug in the changelog, I think we should probably close it
> for them. Yes, this is currently not how it works, but I think that's
> actually a bug. It also currently prevents the changes done to the
> Debian package between the base version and the new version from showing
> up on *-changes where Ubuntu does a new upstream before Debian and
> Debian subsequently makes changes while it has the previous version.

This would be alright for me too, but I wouldn't be bothered if it were
the other way really (as I don't think this is much of a problem in
practice).

[Launchpad QA Bot (lpqabot)]

Fixed in stable r13835 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/13835>.

[Julian Edwards (julian-edwards)]

Last branch qa-ok but it doesn't fix the problem yet.

[Launchpad QA Bot (lpqabot)]

Fixed in stable r13886 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/13886>.