humanity-icon-theme: black magnifier icons on dark toolbars have contrast issues

[Paul Sladen]

Cimi noticed that some icons from lp:elementaryicons into the ubuntu-mono package.

The icons that need deleting/replacing are:

  The magnifier icons used for find, find & replace, and zoom levels

because:

  Several action icons look crap on the new dark toolbars introduced in the light themes.

[Paul Sladen (sladen)]

<danrabbit> The changes involve action icons in Humanity.

[Vish (vish)]

I can't see any icon list in the bug description.
@Cimi, what icons need merging?

[Andrea Cimitan (cimi)]

@vish: just use the new trunk, nothing has to be merged, some instead removed.

[Paul Sladen (sladen)]

Vish: yes, quite, that big space was a placeholder for Cimi/Danrabbit to fill in exactly what needed merging/replacing/updating. It's still a placeholder but guess per comment #3 apparently only involves removals.

[Paul Sladen (sladen)]

Dan/Cimi: some more detail about what exactly is the request, would still be handy; the delta is 60 MB and 400 revisions:

  $ du --exclude .bzr* -sch humanity elementaryicons
  69M humanity
  137M elementaryicons

[Vish (vish)]

Could someone attach a screenshot of what problem we are trying to solve by removing icons?
I *think* we can fix this without removing icons.

[Danielle Foré (danrabbit)]

There was a need this cycle to make sure that Humanity icons look okay on the new dark toolbars.

There have been several changes in action icons, along with adding more sizes of these icons.

The magnifier icons have been removed since they are very difficult to see. There are plans to create new magnifier icons, this is just a "quick fix".

[Paul Sladen (sladen)]

Dan: Thanks for that lead about the dark toolbars; are there any other contextual emails/bug report numbers or the like that you have to hand to give more background/details/context/examples. Are we talking about:

  ./Humanity/actions/*/viewmag*.svg

?

[Danielle Foré (danrabbit)]

Here's a bug report: https://bugs.launchpad.net/humanity/+bug/833271

It involves both the zoom level icons and the find/find-replace icons specifically, yes.

[Vish (vish)]

@Dan: Yea, I'm pushing an update with magnifier icons similar style to the Unity icons.. get on IRC! ;p

[Paul Sladen (sladen)]

So, as I understand, there are two options available:

  a. rm humanity/Humanity/actions/24/{viewmag{1,-,+,fit},zoom-{best-fit,fit-best,in,original,out}.svg

thus allowing the default gnome-icon-theme versions to shine through; or, to development replacements and install those at:

  b. humanity/Humanity-Dark/actions/24/{viewmag{1,-,+,fit},zoom-{best-fit,fit-best,in,original,out}.svg

This is correct? Are there any icons I've missed from the list (eg. 'window-close.svg' and 'media-eject.svg' appear to have the same sort of dark palette)?

[Vish (vish)]

Looks like Dan is working on icons (tango style?); if its not done within the week we could remove the icons.

If we are removing the icons from Humanity now and then adding them later next week with a new style, We'd be changing the UI twice in a week. IMO, we can do the change once within next week, either removing or updating the icons

[Andrea Cimitan (cimi)]

We can't. UI Freeze is tomorrow at 21UTC. We should just update the package with the new icons by dan.
WE MUST HAVE A PACKAGE UPLOADED WITH THE FIX FOR BOTH AMBIANCE AND RADIANCE :-)
Loud and clear, roger :)

[Paul Sladen (sladen)]

I think the point is that Dan might not have the icons (which exact ones?) done by 2100UTC today; in which case we're left with the single option of dropping the icons in question (which exact ones?).

[Paul Sladen (sladen)]

  <Cimi> sladen: oh my god, ok. I'll ask kenvandine when he wakes up

Ken: any ideas? You're welcome to upload this if you can figure out what's needed.

[Paul Sladen (sladen)]

  <Cimi> sladen: we can't ship black magnifier icons on dark toolbars, so you should have a look at which icons need to be updated and update them

[Paul Sladen (sladen)]

Cimi: ta.

[Andrea Cimitan (cimi)]

 take commit 844 of lp:elementaryicons, look at which icons were removed (they should be mags and so) and which changes are requested in index.theme (if there are any, I doubt), backport them into ubuntu humanity icons, then we have done.

[Paul Sladen (sladen)]

Cimi: Purfect; I'm intending to apply:

  $ time bzr diff lp:elementaryicons -r843..844 | grep '^=== removed' | cut -f2 -d\' | cut -d/ -f2- | xargs ls -1 | sed -e 'sX/[0-9][0-9]*/X/*/X' | sort | uniq
  Humanity/actions/*/edit-find-replace.svg
  Humanity/actions/*/edit-find.svg
  Humanity/actions/*/filefind.svg
  Humanity/actions/*/find.svg
  Humanity/actions/*/gnome-searchtool.svg
  Humanity/actions/*/gtk-find-and-replace.svg
  Humanity/actions/*/gtk-find.svg
  Humanity/actions/*/gtk-search.svg
  Humanity/actions/*/gtk-zoom-100.svg
  Humanity/actions/*/gtk-zoom-fit.svg
  Humanity/actions/*/gtk-zoom-in.svg
  Humanity/actions/*/gtk-zoom-out.svg
  Humanity/actions/*/kfind.svg
  Humanity/actions/*/search.svg
  Humanity/actions/*/stock_search-and-replace.svg
  Humanity/actions/*/stock_search.svg
  Humanity/actions/*/stock_zoom-1.svg
  Humanity/actions/*/stock_zoom-in.svg
  Humanity/actions/*/stock_zoom-out.svg
  Humanity/actions/*/stock_zoom-page.svg
  Humanity/actions/*/system-search.svg
  Humanity/actions/*/viewmag1.svg
  Humanity/actions/*/viewmagfit.svg
  Humanity/actions/*/viewmag-.svg
  Humanity/actions/*/viewmag+.svg
  Humanity/actions/*/zoom-best-fit.svg
  Humanity/actions/*/zoom-fit-best.svg
  Humanity/actions/*/zoom-in.svg
  Humanity/actions/*/zoom-original.svg
  Humanity/actions/*/zoom-out.svg

  … | xargs bzr rm

[Andrea Cimitan (cimi)]

Good Paul, I don't have time to test it but I trust you. Be sure to upload
the package in time for UI FREEZE
Il giorno 25/ago/2011 13:40, "Launchpad Bug Tracker" <
<email address hidden>> ha scritto:
> ** Branch linked: lp:~sladen/humanity/lp-832170-dark-on-dark-toolbar-
> removals
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/832170
>
> Title:
> humanity-icon-theme: black magnifier icons on dark toolbars have
> contrast issues
>
> Status in “humanity-icon-theme” package in Ubuntu:
> Triaged
>
> Bug description:
> Cimi noticed that some icons from lp:elementaryicons into the ubuntu-
> mono package.
>
> The icons that need deleting/replacing are:
>
> The magnifier icons used for find, find & replace, and zoom levels
>
> because:
>
> Several action icons look crap on the new dark toolbars introduced
> in the light themes.
>
> To manage notifications about this bug go to:
>
https://bugs.launchpad.net/ubuntu/+source/humanity-icon-theme/+bug/832170/+subscriptions

[Launchpad Janitor (janitor)]

This bug was fixed in the package humanity-icon-theme - 0.5.3.11

---------------
humanity-icon-theme (0.5.3.11) oneiric; urgency=low

  [Andrea Cimitan]
  * Remove dark icons on dark toolbars that have low contrast (LP: #832170)
    Cherry-pick deletions from upstream revision lp:elementaryicons -r844
    Removals:
    - Humanity/actions/*/edit-find{,-replace}.svg
    - Humanity/actions/*/{file,,k}find.svg
    - Humanity/actions/*/gnome-searchtool.svg
    - Humanity/actions/*/gtk-{find{,-and-replace},search,zoom-{100,fit,in,out}}.svg
    - Humanity/actions/*/{,system-}search.svg
    - Humanity/actions/*/stock_{search{,-and-replace},zoom-{1,in,out,page}}.svg
    - Humanity/actions/*/viewmag{1,fit,-,+}.svg
    - Humanity/actions/*/zoom-{best-fit,fit-best,in,original,out}.svg
 -- Paul Sladen <email address hidden> Thu, 25 Aug 2011 20:59:59 +0000

[Dmitry Shachnev (mitya57)]

We still need better search icons in ubuntu-mono, see bug 909603 for that.