OpenStack Object Storage (swift)

swift-drive-audit does not work with > 26 drives

Bug #827913 reported by SaveTheRbtz
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Object Storage (swift)
Fix Released
High
Mike Barton
OpenStack Object Storage (swift) 1.4.4

Bug Description

swift-drive-audit has two regexps

error_re = [
    'error.*(sd[a-z])',
    '(sd[a-z]).*error',
]

If system has lots of disks their name can be like sdaa, sdab, sdac ... etc, which will be captured by regexps incorrectly.

Patch attached.

Revision history for this message
SaveTheRbtz (savetherbtz) wrote :
Revision history for this message
Mike Barton (redbo) wrote :

I'd like to see word boundaries around the drive name. Maybe something like r'error.*\b(sd[a-z]{1,2})\b'

Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : A change has been merged to openstack/swift

Reviewed: https://review.openstack.org/755
Committed: http://github.com/openstack/swift/commit/b3c28004975f61cf37a5eba085c771affca59eb8
Submitter: Jenkins
Branch: master

 status fixcommitted
 done

commit b3c28004975f61cf37a5eba085c771affca59eb8
Author: Mike Barton <email address hidden>
Date: Fri Sep 30 00:17:35 2011 +0000

    make drive audit regexes detect 4-letter drives

    addresses bug 827913

    Change-Id: I691eee191f5951186158c553281f88aae9e5d25f

Changed in swift:
status: New → Fix Committed
John Dickinson (notmyname)
Changed in swift:
milestone: none → 1.4.4
importance: Undecided → High
assignee: nobody → Mike Barton (redbo)
Thierry Carrez (ttx)
Changed in swift:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.