PHPMailer causes "headers sent" errors when given invalid addresses
Bug #823058 reported by
Richard Mansfield
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Mahara |
Fix Released
|
Low
|
Richard Mansfield | ||
Bug Description
When a bad address is passed to PHPMailer, it produces output. When output_buffering is off in php.ini, a subsequent mahara redirect() call produces an unnecessary big red "Something bad happened after headers were sent" message. We should turn exceptions on in phpmailer, and catch them, to stop phpmailer from outputting its error messages. Then we can keep the "headers sent" messages for when we really need them.
| Changed in mahara: | |
| status: | New → Confirmed |
| importance: | Undecided → Low |
| assignee: | nobody → Richard Mansfield (richard-mansfield) |
| milestone: | none → 1.5.0 |
Revision history for this message
| Mahara Bot (dev-mahara) wrote A change has been merged | #1 |
| Changed in mahara: | |
| status: | Confirmed → Fix Committed |
| Changed in mahara: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Reviewed: https:/
Committed: http://
Submitter: Hugh Davenport (<email address hidden>)
Branch: master
commit 18d6f25bc4a545e
Author: Richard Mansfield <email address hidden>
Date: Tue Aug 9 16:45:26 2011 +1200
Enable exceptions in phpmailer (bug #823058)
This stops phpmailer from unnecessarily sending output to the page.
Change-Id: Ib7ed71de4b5400
Signed-off-by: Richard Mansfield <email address hidden>