fwts: broken _CRS objects with zero sized access bit widths cause division by zero error

Bug #816877 reported by Colin Ian King
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
fwts (Ubuntu)
Fix Released
Low
Colin Ian King

Bug Description

Running the fwts method test against an ACPI table with a broken _CRS object with a zero sized bit with causes a division by zero error.

Related branches

Revision history for this message
Colin Ian King (colin-king) wrote :

Fixed in commit 569c3f6f15b594bc6ba027219e3b4b8e36544ab9

Changed in fwts (Ubuntu):
status: New → In Progress
importance: Undecided → Low
assignee: nobody → Colin King (colin-king)
status: In Progress → Fix Committed
Revision history for this message
Colin Ian King (colin-king) wrote :

Actually, commit 1a84b44ab480c4c4a863754a1d5a8bee85745e26 properly fixes this.

Revision history for this message
Colin Ian King (colin-king) wrote :

A newer version 0.23.13 of fwts is available which fixes this bug and has a load of minor fixes the Oneiric release.

It can be found in my PPA:

https://launchpad.net/~colin-king/+archive/ppa/+packages

Can this be uploaded this to Oneiric universe?

This new version includes the following changes since V0.23.11

    lib + method test: better handling of object eval errors.
    acpi: method: check for NULL _DDC and _UID object returns.
    acpi: method: only derefernce non-null _DOD objects (LP: #816824)
    lib: acpica: make hash unsigned int (LP: #816819)
    acpi: syntaxcheck: don't errnoenously put syntaxcheck_table.
    cmosdump: print drive info with %hhu and pluralise.
    mpcheck: print uint8_t values with %hhu
    mtrr: print entry reg as uint8_t.
    bios32: print bios32 values in hex.
    fadt: ensure we print out preferred_pm_profile as 8 bit int.
    acpitables: ensure we are printing out correct int values.
    acpi: wmi: fix typo in test identifier.
    lib + tests: add unique test label that identifies each failure test.
    lib + tests: replace fwts_failed_low with fwts_failed.
    lib + tests: replace fwts_failed_medium with fwts_failed.
    lib + tests: replace fwts_failed_high with fwts_failed.
    lib + tests: replace fwts_failed_critical with fwts_failed.
    lib: remove fwts_failed_level macro
    lib + tests: fwts_failed now includes log level.
    lib: fix ARM FTBFS (LP: #814745)
    apcica lib: fake PCI config reads (LP: #813376)

Revision history for this message
Colin Ian King (colin-king) wrote :

Attached: Differences between V0.23.11 and V0.23.13

Revision history for this message
Colin Ian King (colin-king) wrote :

Just to add, I've tested this for regressions against 7,500+ data sets.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package fwts - 0.23.13

---------------
fwts (0.23.13) oneiric; urgency=low

  * lib + method test: better handling of object eval errors. (LP: #816877)
  * apci: method: detect zero sized access bit width (LP: #816877)
  * acpi: method: check for NULL _DDC and _UID object returns.
  * acpi: method: only derefernce non-null _DOD objects (LP: #816824)
  * lib: acpica: make hash unsigned int (LP: #816819)
  * acpi: syntaxcheck: don't erroneously put syntaxcheck_table.
  * cmosdump: print drive info with %hhu and pluralise.
  * mpcheck: print uint8_t values with %hhu
  * mtrr: print entry reg as uint8_t.
  * bios32: print bios32 values in hex.
  * fadt: ensure we print out preferred_pm_profile as 8 bit int.
  * acpitables: ensure we are printing out correct int values.
  * acpi: wmi: fix typo in test identifier.

fwts (0.23.12) oneiric; urgency=low

  * lib + tests: add unique test label that identifies each failure test.
  * lib + tests: replace fwts_failed_low with fwts_failed.
  * lib + tests: replace fwts_failed_medium with fwts_failed.
  * lib + tests: replace fwts_failed_high with fwts_failed.
  * lib + tests: replace fwts_failed_critical with fwts_failed.
  * lib: remove fwts_failed_level macro
  * lib + tests: fwts_failed now includes log level.
  * lib: fix ARM FTBFS (LP: #814745)
  * apcica lib: fake PCI config reads (LP: #813376)
 -- Colin King <email address hidden> Wed, 27 Jul 2011 14:17:23 +0100

Changed in fwts (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.