Blocktype icons cannot be overridden in themes

Bug #815603 reported by Richard Mansfield
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Wishlist
Richard Mansfield

Bug Description

Blocktype icons in the view editor can't be overridden in child themes. Other images can, and it's easy enough to fix this by making thumb.php look in the current theme directory for the icons, instead of looking in the blocktype's base directrory.

Tags: newfeature
Changed in mahara:
status: New → Confirmed
importance: Undecided → Wishlist
assignee: nobody → Richard Mansfield (richard-mansfield)
milestone: none → 1.5.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/517
Committed: http://gitorious.org/mahara/mahara/commit/f227745d46d685540bc07ba720927b7d1a530e96
Submitter: Richard Mansfield (<email address hidden>)
Branch: master

commit f227745d46d685540bc07ba720927b7d1a530e96
Author: Richard Mansfield <email address hidden>
Date: Mon Jul 25 10:58:39 2011 +1200

    Allow blocktype icons to be themeable (bug #815603)

    The current theme is now searched for the blocktype thumb.png icon.
    This change also moves the existing blocktype icons from the blocktype
    base directory into theme/raw/static/images. To ensure 3rd party
    blocktype icons continue to work, thumb.png icons in the base directory
    will still be displayed if no icon is found in the raw theme.

    Change-Id: If9f6a00f69799806fbf28384e00fe43f7e190f48
    Signed-off-by: Richard Mansfield <email address hidden>

Changed in mahara:
status: Confirmed → Fix Committed
tags: added: newfeature
Revision history for this message
Melissa Draper (melissa) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

 status fixreleased
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJPjrXHAAoJECXBtiziiXdcU94IALII/v8XTSOgD0jBkOXYzDms
uLkrvC+Z5YqYhQVjIR5cVYg7X3SJPUjuaorS2uVVfIkGlz+38KdZdczOYV+JaNQV
S8aVo/Rqrsx8h6fKtVAgTl8bd1CCMos1YnrOTNvqoYSOV2iGSSX/paQf6R9BjDbz
hx6GM7pkUp/gOa3Zqo+E6NfUrMWASanjbh9kbHdm09L7/10f7a5Q9w2Cf5o1yjC7
xqM9hEbPe32C9tBBcXDGPzQDFpJ6b6Rys2dzt6NTNkv2FCyzKS4RLwGDUDRNBEEZ
iYxQ5wJJaxW+/RO8k4lGYSo7Mtt99aIxhkQX7DKxcEoOSNMdPUi9ptwjolgG4iI=
=AeF+
-----END PGP SIGNATURE-----

Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.