Cannot edit a page with a navigation block pointing at a deleted collection
Bug #813204 reported by
Richard Mansfield
This bug affects 3 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mahara |
Fix Released
|
Medium
|
Richard Mansfield |
Bug Description
If you include a navigation block on a page, then delete the collection which the block refers to, you can no longer view or edit the page.
http://
We should just display an empty block rather than throwing the error described in that post.
Changed in mahara: | |
assignee: | nobody → Richard Mansfield (richard-mansfield) |
status: | New → Confirmed |
importance: | Undecided → Medium |
Changed in mahara: | |
milestone: | 1.5.0 → 1.4.1 |
status: | Fix Committed → In Progress |
Changed in mahara: | |
status: | In Progress → Fix Committed |
milestone: | 1.4.1 → 1.5.0 |
Changed in mahara: | |
milestone: | 1.5.0 → 1.4.1 |
Changed in mahara: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Argh, I accidentally pushed this patch straight to refs/heads/master, so it didn't go through gerrit and missed out on being reviewed:
https:/ /gitorious. org/mahara/ mahara/ commit/ e29f0a133e2e7c2 7ccce021d87e3b9 d40d1e5778
If anyone gets a chance, please have a look at it.
It'd also be a good idea to do the right thing and delete navigation blocks when their collection is deleted. It's probably an expensive operation though; the collection id is stored in a serialised blob, so perhaps a cron cleanup is the way to go.