Include a few more page links in the pager

Bug #812113 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Wishlist
Eugene

Bug Description

This is an add on to bug #697843

The pager should always include 2 pages to the left and 2 pages to the right from the current page to allow for quicker access to neighboring pages.

e.g. First - Previous - 4 5 _6_ 7 8 16 24 Next - Last

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

Hi Eugene, as discussed, please also check the functionality on /view/choosetemplate.php

Changed in mahara:
milestone: none → 1.5.0
Eugene (eugenev)
Changed in mahara:
status: New → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/492
Committed: http://gitorious.org/mahara/mahara/commit/bd1f56b3d7abde649abf855e380637b9b4f416b0
Submitter: Richard Mansfield (<email address hidden>)
Branch: master

commit bd1f56b3d7abde649abf855e380637b9b4f416b0
Author: Eugene Venter <email address hidden>
Date: Tue Jul 19 10:48:53 2011 +1200

    get_templatesearch_data() pagination change

    Bug #812113

    Always display first and last page.

    Change-Id: I65607bed4525dab65dc50d7abd23f33f8a550cd6
    Signed-off-by: Eugene Venter <email address hidden>

Revision history for this message
Richard Mansfield (richard-mansfield) wrote :

I think having 2 pages either side, plus up to eight in-between links is too many. It makes the pager wrap for some blocks, even in a 2-column view (see screenshot). The number of in-between links, and the two-either-side setting should be configurable for each paginator by passing different parameters to build_pagination.

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/491
Committed: http://gitorious.org/mahara/mahara/commit/95fd96556fc8caa72b1abb0c1266bc61134982f3
Submitter: Richard Mansfield (<email address hidden>)
Branch: master

commit 95fd96556fc8caa72b1abb0c1266bc61134982f3
Author: Eugene Venter <email address hidden>
Date: Wed Jul 20 15:52:52 2011 +1200

    lib/web.php: Changes to build_pagination()

    Bug #812113

    Implement new parameter options:
    * Number of page jump links
    * Number of adjacent page links to current page (per side)

    Change-Id: I0e6975969bf15f3df5c2206093e2fc3ab0dbb3df
    Signed-off-by: Eugene Venter <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/495
Committed: http://gitorious.org/mahara/mahara/commit/634b54dc1ae5c1995e55d65763df92c348a655bf
Submitter: Richard Mansfield (<email address hidden>)
Branch: master

commit 634b54dc1ae5c1995e55d65763df92c348a655bf
Author: Eugene Venter <email address hidden>
Date: Wed Jul 20 15:55:44 2011 +1200

    Pagination changes

    Bug #812113

    Added 'jumplinks' and 'numbersincludeprevnext' options to some views.

    Change-Id: I7bf296a11c16191369d11983c75e1252df315709
    Signed-off-by: Eugene Venter <email address hidden>

Revision history for this message
François Marier (fmarier) wrote :

It looks like this has been merged.

Changed in mahara:
status: In Progress → Fix Committed
tags: added: newfeature usability
Revision history for this message
Melissa Draper (melissa) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

 status fixreleased
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJPjrXHAAoJECXBtiziiXdcU94IALII/v8XTSOgD0jBkOXYzDms
uLkrvC+Z5YqYhQVjIR5cVYg7X3SJPUjuaorS2uVVfIkGlz+38KdZdczOYV+JaNQV
S8aVo/Rqrsx8h6fKtVAgTl8bd1CCMos1YnrOTNvqoYSOV2iGSSX/paQf6R9BjDbz
hx6GM7pkUp/gOa3Zqo+E6NfUrMWASanjbh9kbHdm09L7/10f7a5Q9w2Cf5o1yjC7
xqM9hEbPe32C9tBBcXDGPzQDFpJ6b6Rys2dzt6NTNkv2FCyzKS4RLwGDUDRNBEEZ
iYxQ5wJJaxW+/RO8k4lGYSo7Mtt99aIxhkQX7DKxcEoOSNMdPUi9ptwjolgG4iI=
=AeF+
-----END PGP SIGNATURE-----

Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.