SIP2 use checkout.full

[Jason Stephenson]

Made some changes to simplify SIP2 checkout per Bill Erickson's suggestion.

OpenILS::SIP::Transaction::Checkout.pm has been modified to use 1 call to open-ils.circ.checkout.full, instead the of the open-ils.circ.checkout.permit and open-ils.circ.checkout dance. Since we're now looping to check for override events, the single call to checkout.full knocks a few lines out of the file and simplifies the logic a bit.

Code is at

git://git.evergreen-ils.org/working/Evergreen.git <email address hidden>/SIP2_checkout_full

[Jason Stephenson (jstephenson)]

Just updated the branch with a further simplification of the logic in OpenILS::SIP::Transaction::Checkout.

[Bill Erickson (berick)]

Minor style/consistency suggestion... cuddle the else's. For example

    if ($is_renew) {
        $method = 'open-ils.circ.renew';
    }
    else {
        $method = 'open-ils.circ.checkout.full';
    }

---
    if ($is_renew) {
        $method = 'open-ils.circ.renew';
    } else {
        $method = 'open-ils.circ.checkout.full';
    }
---

With that and a squash, I think the branch is ready to go.

[Jason Stephenson (jstephenson)]

beurk. i think cuddled else's are ugly and harder to read, but I'll do it.

Have to remember to do that in all my code changes.

[Jason Stephenson (jstephenson)]

Done.

[Bill Erickson (berick)]

Merged to master:

http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=415945711f0888eff19750df18dc0953dc012a01

Thanks Jason!