Missing dependency on python-simplejson

[dobey]

Impact: The python-lazr.restfulclient package on Lucid is missing a dependency on python-simplejson. As a result, anything which uses python-lazr.restfulclient and requires it working at build time via Build-Depends, will fail, due to the missing dependency. A workaround is to explicitly Build-Depends on python-simplejson as well, but this is the incorrect solution.

Development Fix: Already fixed by adding the dependency
Stable Fix: Add the dependency on python-simplejson
Test Case:
  1. Install python-lazr.restfulclient from lucid-updates
  2. Check that it doesn't depend on python-simplejson
  3. Install python-lazr.restfulclient from lucid-proposed
  4. Check that it does depend on python-simplejson
Regression Potential: low, just adding a dependency

[dobey (dobey)]

It looks like the Depends contains "python-simplejson | python (>= 2.6)" which doesn't work, because python 2.6 is installed by default on Lucid, and it does not provide a simplejson module, and lazr.restfulclient.resource does not fall back to just using "json" if simplejson import fails. It requires simplejson at all times.

[Martin Pitt (pitti)]

This is fixed in oneiric.

What is the user impact of this in lucid? It's certainly not an issue with build depends for an SRU?

[dobey (dobey)]

It is low impact for Lucid. I ran into the problem building a package in a PPA that uses lazr.restfulclient, as it would fail in regression tests due to this. I've worked around it, but since this is a very simple and low impact fix, I think we should SRU it to Lucid as well.

[Martin Pitt (pitti)]

It seems a little waste of packaging and QA resources to me, but I don't veto it. So please go ahead and upload it.

[Chris Halse Rogers (raof)]

SRU team ack. Please accept into lucid-proposed.

[Martin Pitt (pitti)]

Hello Rodney, or anyone else affected,

Accepted lazr.restfulclient into lucid-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

[dobey (dobey)]

Does my verification still count, since I both reported and fixed the bug? :)

[Clint Byrum (clint-fewbar)]

Excerpts from Rodney Dawes's message of Wed Jul 20 12:58:53 UTC 2011:
> Does my verification still count, since I both reported and fixed the
> bug? :)

It counts for something, but please do find somebody else who wasn't
involved in doing the fix itself to run through the test case (which I
don't see in the bug description, you should add a TEST CASE: there).

[James Westby (james-w)]

Checked that the new package works fine.

Thanks,

James

[Launchpad Janitor (janitor)]

This bug was fixed in the package lazr.restfulclient - 0.9.11-1ubuntu1.2

---------------
lazr.restfulclient (0.9.11-1ubuntu1.2) lucid-proposed; urgency=low

  * debian/control:
     - Always require python-simplejson as python 2.6 does not provide it
       and lazr.restfulclient.resource does not use json on error instead.
       (LP: #803475)
 -- Rodney Dawes <email address hidden> Thu, 14 Jul 2011 15:55:51 +0200