[Need Packaging] New upstream release 0.143

[Cesare Falco]

New upstream release Mame 0.143 is available

[Cesare Falco (c.falco)]

Hello,

this is the debian.tar for Mame 0.143.

Ubuntu Sponsors, please have a look at it and consider uploading.

Thanks!
Cesare.

[Evan Broder (broder)]

Thanks for your hard work on keeping mame up to date! This looks mostly good, but I have a few issues:

A few questions:

 - In the 0.141 package, mame-tools depended on mame-common. Since you merged that into mame, should mame-tools not depend on mame (= ${source:Version}) now?

 - I see several suggestions for the xmame packages. Will any of them be affected by the merge of mame-common into mame?

 - This is much less important, but have you looked into using dh_usrlocal instead of creating the directories in maintainer scripts yourself? I think you should be able to list the directories in debian/*.dirs and then let dh_usrlocal cleanup.

A few things that definitely should be fixed:

 - So long as the package is still in Ubuntu and not getting synced from Debian, the maintainer should remain an @ubuntu.com e-mail address

 - The Debian Policy manual generally recommends against using Conflicts with a "earlier than" version clause (http://www.debian.org/doc/debian-policy/ch-relationships.html#s-conflicts); you should use Breaks instead. Also, since mame now contains files that were previously in mame-common, mame should also Replaces: mame-common (<< 0.143)

And finally a few notes that will make your changes easier for sponsors to review in the future:

 - It took me a few minutes to realize you had written a get-orig-source target in debian/rules. Since the orig source requires mangling and you didn't attach it directly, it speeds alone the sponsorship process if you mention that directly

 - For version upgrade sponsorship, the thing I'm most interested in seeing as a sponsor is the debdiff between the two releases, preferably just confined to the debian/ directory. Something like `debdiff {a,b}.dsc | filterdiff -i '*/debian/*'` should capture that. Generating and attaching that also makes the package easier to review

I'm going to go ahead and unsubscribe ubuntu-sponsors for the moment. Once you've addressed the issues above, feel free to resubscribe sponsors for another review.

[Micah Gersten (micahg)]

I think Evan meant to set the status to incomplete instead of confirmed.

[Cesare Falco (c.falco)]

@evan: thanks for all your suggestion, which witness how deep you looked inside the package. And teach me a number of new things as well. :)

1. No, mame-tools does not need mame, ldplayer was responsible for such dependency and is now gone. I pointed this out in changelog too.

2. xmame has been a port to X, superseded by mame; the aim is to replace all the installed xmame-* packages with mame. Hence the replace/breaks/conflicts or the like.

3. Good one. dh_usrlocal is now responsible of the /usr/local/share/games/mame dir & subdirs.

4. Maintainer e-mail address recovered. That was a classic "cut & paste" typo. Sorry. :(

5. Fixed dependencies IMHO. Could you please give me your opinion on the new arrangement?

6. get-orig-source is more than a best practice, I learned from MOTU's, so I thought its presence is nearly mandatory. I'll point it out next time however.

7. I understood from the sponsorship queue guidelines debian.tar would suffice for upstream revisions.
https://wiki.ubuntu.com/MOTU/Sponsorship/SponsorsQueue
No problem either. :)

Here we go with the updated archives.

Thank you again!
Cesare.

[Cesare Falco (c.falco)]

Just in case I made something wrong with debdiff, here's the debian.tar as well.

Cesare.

[Benjamin Drung (bdrung)]

It would be nice, if you could sync/merge the package from Debian. This will reduce future maintenance work.

[Cesare Falco (c.falco)]

@benjamin: I'm currently working with the Debian guys in that direction, but there's still some work to be done.
I hope to start syncing with 12.04.

[Micah Gersten (micahg)]

Taking a look

[Launchpad Janitor (janitor)]

This bug was fixed in the package mame - 0.143-0ubuntu1

---------------
mame (0.143-0ubuntu1) oneiric; urgency=low

  * New upstream release (LP: #803468) (LP: #770914)
  * Compress packages and debian.tar using bzip2
  * added hash files
  * let dh_usrlocal take care of /usr/local/share/mame/ and subdirs
  * control:
    - bumped standards version to 3.9.2
    - rearranged conflicting dependencies
  * rules:
    - excluded more non-*nix docs
    - do not consider compiler warnings as errors
  * README.Debian: updated with hash files info
  * contrib/mame.ini: added hash file entry
  * mame-common: merged with main package (prepares future import from Debian)
  * mame-tools: removed ldplayer, in sync with upstream distribution; this also
        removed mame-tools dependency on mame-common
 -- Cesare Falco <email address hidden> Wed, 03 Aug 2011 22:27:36 -0500

[Micah Gersten (micahg)]

Thanks Cesare, everything seems to have been addressed. I just ran wrap-and-sort -s to clean up the extra spaces in debian/control. It looked like you were trying to emulate that spacing in any event.

[Micah Gersten (micahg)]

Now that I think about it, I should've noted that in the changelog as well...next time :)