Journal pager shows up too early

[François Marier]

Version: 1.4.0

If you create 10 journals, they are all displayed on the index page, but the pager shows up and displays only 1 available page. When you have 9 journals, it works fine and the pager is hidden.

We should only display the pager when there are more than 1 page worth of journals (i.e. after you add the 11th journal).

[Hugh Davenport (hugh-davenport)]

This also happens with page comments, and I would assume that it happens with any paginated list

[MikaelM (mikael-mr)]

Patch attached.
Modified build_pagination function in htdocs/lib/web.php

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/416
Committed: http://gitorious.org/mahara/mahara/commit/5935922911b5573c51cf1a02e8f2410c03f920a2
Submitter: Francois Marier (<email address hidden>)
Branch: master

commit 5935922911b5573c51cf1a02e8f2410c03f920a2
Author: Mikael Mrozik <email address hidden>
Date: Thu Jun 30 11:37:13 2011 +1200

    Only display the pager when needed (bug #800943)

    The pager was displayed erroneously when the total number
    of items was equal to the limit per page

    Change-Id: I93f01f7a3a3b80a46487a35aaf232680a4e67752
    Signed-off-by: Mikael Mrozik <email address hidden>

[Don Presant (don-learningagents)]

I think it's worse than that...the pager does not work properly for 11 or more Journals.

I cannot access the 11th journal - the links to page 2 & end don't work. I was forced to delete a journal on the first page to get access to a journal that had been pushed to page 2.