Feature: Add usertags

[Hugh Davenport]

Add support for user tags, they can be changed on user edit pages

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/366
Committed: http://gitorious.org/mahara/mahara/commit/f3cd4efe47a3c070c9e80eab8c3c05fe8a12cffd
Submitter: Francois Marier (<email address hidden>)
Branch: master

commit f3cd4efe47a3c070c9e80eab8c3c05fe8a12cffd
Author: Hugh Davenport <email address hidden>
Date: Wed Jun 22 10:37:02 2011 +1200

    Add usr_tag table

    Adds a table to store user tags. These tags will be used
    in the future for search queries, and the potential for
    other uses

    Bug #800926

    Change-Id: Ia7b040790a9bf8e0b5833aaf7ca7e0f787f1289e
    Signed-off-by: Hugh Davenport <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/367
Committed: http://gitorious.org/mahara/mahara/commit/efe0c152014fcbd87f0e30a9d4d6c81d526afb63
Submitter: Francois Marier (<email address hidden>)
Branch: master

commit efe0c152014fcbd87f0e30a9d4d6c81d526afb63
Author: Hugh Davenport <email address hidden>
Date: Wed Jun 22 11:31:52 2011 +1200

    Add tags to user edit page

    Bug #800926

    Change-Id: I9c7a2a6c5c3a051e99e8caf59335d0e4d64bd8da
    Signed-off-by: Hugh Davenport <email address hidden>

[Ruslan Kabalin (rkabalin)]

Hey Hugh, great feature, I like it!

I am thinking, perhaps you could just push all usertags-related changes at once when they are ready, or at least push stuff related to the same things at the same time. For instance https://reviews.mahara.org/#change,367 adds tags to user edit page. Well, it works for site admin, but not for institution admin (edituser_institution_submit function) and I am not sure if that is something you missed or have not pushed yet.

[Hugh Davenport (hugh-davenport)]

Hi Ruslan,

Seems to work for me with institutional administrators. The edituser_institution_submit function is used to add/remove/update users to/from/for institutions, and doesn't involve the tags.

Cheers,

Hugh

[Ruslan Kabalin (rkabalin)]

True, it works for inst admin, sorry. I encountered another bug (that sql error) and did not look into my assumption properly. But this was just as example of what I mean. It is just easier for reviewer to look through the whole feature (a series of patches) rather than checking them one by one.

What about searching by tag for general user search (admin/users/search.php)? It is obviously would be quite useful to have that search as well.

[Ruslan Kabalin (rkabalin)]

With regard to lastinistitution tag, it definitely should not be visible in the user account edit page. Perhaps we have to add visibility flag column to 'user_tag' table and differentiate system tags (like lastinistitution) and the custom ones?

[Melissa Draper (melissa)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

status fixreleased
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJPjqdlAAoJECXBtiziiXdcxeoH/iQi1ljFCaDUrA07cq6IAZga
p3Tw7VRtZBy6Cl5NwOFg1b4/DsqFIM9fQPb+WpJqUAcTVP6B44QElOCtb0ldeZCw
cgWlkkSj1jk/gpCdKhCZ2MMHkRjMao5ZpUyF4vSO26tIiYcvPIhRoF6uWu0Z40xe
1wee4ZKGEEvO13bujMyuu4nEQSd9TK5VWPn+PbIKFEyJgCY19Zw62fWBXoanPbWj
LDuO9AnaQOPyVEx2qtoH8M5LFra2zq+dZ9Ac7oAiLffcWJAB9MqL8o2zbQHpOuVi
Ynrh6BIyUYaqdt1BhALrJ6/MQ0h7mDKGy8CVg0z4e2VHyxecYwc84kwzrItH7I0=
=mdeb
-----END PGP SIGNATURE-----

[Melissa Draper (melissa)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

 status fixreleased
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJPjrXHAAoJECXBtiziiXdcU94IALII/v8XTSOgD0jBkOXYzDms
uLkrvC+Z5YqYhQVjIR5cVYg7X3SJPUjuaorS2uVVfIkGlz+38KdZdczOYV+JaNQV
S8aVo/Rqrsx8h6fKtVAgTl8bd1CCMos1YnrOTNvqoYSOV2iGSSX/paQf6R9BjDbz
hx6GM7pkUp/gOa3Zqo+E6NfUrMWASanjbh9kbHdm09L7/10f7a5Q9w2Cf5o1yjC7
xqM9hEbPe32C9tBBcXDGPzQDFpJ6b6Rys2dzt6NTNkv2FCyzKS4RLwGDUDRNBEEZ
iYxQ5wJJaxW+/RO8k4lGYSo7Mtt99aIxhkQX7DKxcEoOSNMdPUi9ptwjolgG4iI=
=AeF+
-----END PGP SIGNATURE-----