pyPdf shouldn't be removed since it is modified by upstream

[Michael Wild]

The upstream calibre developers enclose a modified version of pyPdf in their package, which means that some utilities (e.g. "pdfmanipulate crop") can't work with the standard python-pypdf package.

This is on Natty, with calibre 0.7.44+dfsg-1build1.

[Michael Wild (themiwi)]

Attached patch fixes the issue for me.

[Fabrice Coutadeur (fabricesp)]

Hi,

Could you please indicate which error(s) you are getting and what action you're doing or command you are running to get them?

Thanks,
Fabrice

[Michael Wild (themiwi)]

As I said, I tried "pdfmanipulate crop". For an easier example resulting in the same error, try

$ pdfmanipulate reverse -o tmp-r.pdf tmp.pdf
Traceback (most recent call last):
  File "/usr/bin/pdfmanipulate", line 19, in <module>
    sys.exit(main())
  File "/usr/lib/calibre/calibre/ebooks/pdf/manipulate/cli.py", line 61, in main
    return COMMANDS[command].main(args, command)
  File "/usr/lib/calibre/calibre/ebooks/pdf/manipulate/reverse.py", line 101, in main
    reverse(args[0], opts.output, mi)
  File "/usr/lib/calibre/calibre/ebooks/pdf/manipulate/reverse.py", line 69, in reverse
    out_pdf = PdfFileWriter(title=title, author=author)
TypeError: __init__() got an unexpected keyword argument 'title'

[Fabrice Coutadeur (fabricesp)]

reproduced here too

[Launchpad Janitor (janitor)]

This bug was fixed in the package calibre - 0.8.2+dfsg-1ubuntu1

---------------
calibre (0.8.2+dfsg-1ubuntu1) oneiric; urgency=low

  * Don't remove pyPdf from installation, it is a modified version (LP: #800551)
    - debian/control: drop dependencies on python-pypdf
    - debian/rules: do not remove pyPdf directory
    - debian/calibre.install: install usr/lib/calibre/pyPdf
 -- Michael Wild <email address hidden> Wed, 22 Jun 2011 09:51:47 +0200

[Fabrice Coutadeur (fabricesp)]

Uploaded. Thanks for your contribution!

I updated a bit the changelog to detail each changes and updated the version and release to follow the Ubuntu policy.
I also ran update-maintainer to update the mantainer to Motus.

thanks again,
Fabrice

[Michael Wild (themiwi)]

Many thanks!