Details link in person picker is confusing

[Diogo Matsubara]

The 'Details...' link shown in the person pickers is confusing. Some notes from the exploratory testing:
- link should be blue as it currently opens up a new page rather than affecting the contents in the overlay;
- elipses implies an action in the current page
- wording is confusing. Suggestion from Huw is to change it to View profile
- LEP says in the must not section, item 1, that looking at a second page to see more details shouldn't be part of the workflow

[Curtis Hovey (sinzui)]

Conistent display of tangential links

We want to do a UI test to discover a better want to convey tangential links. By tangential I mean links that are provide details take you focus from the current task. There are two types of tangential link in Launchpad that I know of
    * Off-site links that will take you away from Launchpad
    * A digressive link to a Launchpad page that takes you away from
      a task that does not loose what you have done

Off-site links are blue and use a globe icon. They use rel="nofollow" to tell robots to ignore them. However not all off-site links have a globe. Comments often contain offsite links that do not have a globe.

Digressive links are green or blue and they open a new window to ensure you can return to your task. However, green means the action will not take you away from your current view. Green and opening a new window are contradictory. Blue is scary because every experienced Launchpad user knows it will leave the form you have spent 5 minutes to enter data. Everyone can see this ambiguities in the list of similar bugs shown you you report a new bug. The "view this bug" link will never be followed by a user that has spent 5 minutes uploading apport data. I have read the implementation of the link, but my distrust is so deep that I always use key commands to ensure link opens another window. Beta tests can see a green version of the green "detail..." when choosing a person from a picker. We want a blue link with iconic and textual information to explain a new window will be opened.

[Jonathan Lange (jml)]

Blue is scary, but in this case appropriately so. Viewing a profile takes you to a new page.

[j.c.sackett (jcsackett)]

Per user testing, we have found an icon to represent this.

[Curtis Hovey (sinzui)]

Huw has a proposed icon for this. We can use it when he provides it. I think this needs to be added to the sprite. I believe this icon will always appear after the link. We may need to resurrect some old css rules where the icon was position 100% to the right.

[William Grant (wgrant)]

r13605 has an XSS hole (in "'<a class="sprite yes save" href="#">Select ' + data.title + '</a>'"). It also hides the experimental UI behind a feature flag which is already turned on by default on production, which seems less than ideal.

r13606 reverts it.

[Curtis Hovey (sinzui)]

I have a fix for the xss an flag and will have it in review shortly.

[Launchpad QA Bot (lpqabot)]

Fixed in stable r13615 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/13615>.