Duplicity ignores some FatalErrors
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Duplicity |
Fix Released
|
Medium
|
Unassigned |
Bug Description
When running a backup after the previous backup attempt failed (to the same target directory), an error similar to the following will be reported: "Backup location ‘/smb:/
The Deja Dup frontend treats this is a fatal error and reports to the user that the backup has failed, however Duplicity continues to operate in the background until Deja Dup is closed. DD should not treat this as a fatal error and should continue to report progress information as usual while Duplicity runs the backup.
Another, possibly separate (Duplicity?) wrinkle to this bug is the fact that this error will occur even if the contents of the target directory have been removed after the failed backup but before the new attempt. Only changing the target directory will stop this error from occurring.
Error is on line 60 of the attached log excerpt
As reported in https:/
Related branches
- duplicity-team: Pending requested
-
Diff: 374 lines (+37/-37)17 files modifiedduplicity-bin (+2/-2)
duplicity/backend.py (+9/-9)
duplicity/backends/ftpbackend.py (+1/-1)
duplicity/backends/ftpsbackend.py (+1/-1)
duplicity/backends/hsibackend.py (+1/-1)
duplicity/backends/imapbackend.py (+1/-1)
duplicity/backends/localbackend.py (+1/-1)
duplicity/collections.py (+2/-2)
duplicity/commandline.py (+3/-3)
duplicity/dup_temp.py (+1/-1)
duplicity/gpg.py (+6/-6)
duplicity/manifest.py (+1/-1)
duplicity/pexpect.py (+3/-3)
duplicity/selection.py (+1/-1)
duplicity/tempdir.py (+2/-2)
testing/backendtest.py (+1/-1)
testing/config.py.tmpl (+1/-1)
Changed in duplicity: | |
milestone: | none → 0.6.14 |
status: | Triaged → Fix Committed |
Changed in duplicity: | |
importance: | Undecided → Medium |
Changed in duplicity: | |
status: | Fix Committed → Fix Released |
There are seemingly two bugs here: one is the error message itself, the other is that DD continues in the background after receiving what it thought was a fatal error.
The first one is, I believe, fixed with my 'retry' patch that made it into Duplicity. I had it ignore 'not found' errors when trying to delete files, which is what happened here. The cache indicated that it had left a .part file, but it wasn't there when it tried to delete it, so the backend errored out. But it shouldn't. So now that that's in Duplicity, I'm not worried about that message.
However, the second part where DD was ignoring the fatal error and secretly continuing is bad. I'm looking at that.