Linaro Image Tools

Allow empty lines in Snowball startfiles.cfg

Bug #797135 reported by Mattias Backman
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Linaro Image Tools
Fix Released
Low
Mattias Backman
Linaro Image Tools 2011.12

Bug Description

The startfiles.cfg parsing does not allow empty lines which is a problem since execution breaks when a user has for instance left a trailing empty line.

The affected code is in boards.py in the get_file_info(cls, bin_dir) function.

Related branches

lp:~leonid-kudryavtsev-deactivatedaccount/linaro-image-tools/797135-suggested-idea (Merged)
lp:~mabac/linaro-image-tools/bug-797135-snowball-whitespace
Guilherme Salgado (community): Approve
Diff: 26 lines (+5/-0)
2 files modified
linaro_image_tools/media_create/boards.py (+3/-0)
linaro_image_tools/media_create/tests/test_media_create.py (+2/-0)
Loïc Minier (lool)
Changed in linaro-image-tools:
importance: Undecided → Low
status: New → Triaged
Revision history for this message
Leonid (leonid-kudryavtsev-deactivatedaccount) wrote :

An idea for the possible solution is attached.

Revision history for this message
Mattias Backman (mabac) wrote : Re: [Bug 797135] Re: Allow empty lines in Snowball startfiles.cfg

On Wed, Nov 2, 2011 at 5:27 PM, Leonid <email address hidden> wrote:
> An idea for the possible solution is attached.

Cool, thanks. So the exercise for tomorrow will be to push your branch
to launchpad and use the lp features for proposing a merge. If you can
find your way using the documentation that's good and if you are stuck
I'll be available to assist after the plenaries.

Cheers,

Mattias

>
> ** Patch added: "current proposal (NOT tested yet)"
>   https://bugs.launchpad.net/linaro-image-tools/+bug/797135/+attachment/2583505/+files/797135_untested.patch
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/797135
>
> Title:
>  Allow empty lines in Snowball startfiles.cfg
>
> Status in Linaro Image Tools:
>  Triaged
>
> Bug description:
>  The startfiles.cfg parsing does not allow empty lines which is a
>  problem since execution breaks when a user has for instance left a
>  trailing empty line.
>
>  The affected code is in boards.py  in the get_file_info(cls, bin_dir)
>  function.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/linaro-image-tools/+bug/797135/+subscriptions
>

Revision history for this message
Leonid (leonid-kudryavtsev-deactivatedaccount) wrote :

Hi Mattias!

On 2 November 2011 23:30, Mattias Backman <email address hidden> wrote:
> On Wed, Nov 2, 2011 at 5:27 PM, Leonid <email address hidden> wrote:
>> An idea for the possible solution is attached.
>
> Cool, thanks. So the exercise for tomorrow will be to push your branch
> to launchpad and use the lp features for proposing a merge. If you can
> find your way using the documentation that's good and if you are stuck
> I'll be available to assist after the plenaries.

Sure, I can invest time in this and finally find the way.
If this is a point of an ughm.. excercise.

--
-- WBR, Leonid

Revision history for this message
Mattias Backman (mabac) wrote :

Leonid started the work, but his account has been removed so cannot assign to him.

Changed in linaro-image-tools:
assignee: nobody → Mattias Backman (mabac)
milestone: none → 2011.12
status: Triaged → Fix Committed
Fathi Boudra (fboudra)
Changed in linaro-image-tools:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.