%#d doesn't work on Solaris, OSX and BSD

[Steve Bailey]

The day of the month (e.g. 1st, 3rd, etc.) in Tasks within a Plan are all displayed as "#d" in Mahara 1.4 rc4. This only happens when viewing tasks (although both in Content>Plans and the block within a Page), as when editing the date appears in full. I'm running this using XAMPP on OSX, MySQL5. Appears in all browsers tested on Mac & PC.

[François Marier (fmarier)]

That looks like an incompatibility with PHP on OSX, because it works fine on Linux.

I'm not entirely surprised because we've had a similar problem on Windows.

[Worth Bishop (wbishop)]

Same problem running Mahara 1.4.0 under FreeBSD 8.0, PostgreSQL 8.3, PHP 5.3.3.

[François Marier (fmarier)]

I guess we either need to switch to using %d and get used to seeing leading zeroes all over the place, or we need to write a wrapper function that will get used whenever we need to print a date.

[Melissa Draper (melissa)]

I've pushed https://reviews.mahara.org/917 for this.

Steve and Worth, if you're able to, could you check if this patch helps? Let us know if you need to be walked through doing so.

[Steve Bailey (stevobailey)]

Thanks for this, but it doesn't seem to work. I applied the patch (after reading up on that), and checked that the changes have been made in the patch (I used the backup option), and this seems to have been applied. However, the day number now doesn't appear at all; it just shows the month and year. I've attached a screen shot. Let me know if you'd like me to upload any other files.

[Melissa Draper (melissa)]

Hi Steve,

Thanks for checking the patch for us, it's very much appreciated.

I can see I didn't clean it up very well, so here is an updated version for you to try.

Thanks
Melissa

[Steve Bailey (stevobailey)]

No problem at all Melissa, just glad I can be of some (minor) help, and thank you for your work on this. This patch works a treat on my system (Mac OSX Lion, XAMPP). Screen shot attached for comparison. Steve

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/919
Committed: http://gitorious.org/mahara/mahara/commit/56b3b65620a1d70c309a7e07686eed61fcce6ec1
Submitter: Hugh Davenport (<email address hidden>)
Branch: master

commit 56b3b65620a1d70c309a7e07686eed61fcce6ec1
Author: Francois Marier <email address hidden>
Date: Fri Dec 9 14:59:44 2011 +1300

    Work-around missing %e in format_date on Windows

    This comes from:

      http://nz.php.net/manual/en/function.strftime.php#example-665

    Bug #795494

    Change-Id: Ie958f1ac6cfcb89dfa34f552c7eeec16be4578d7
    Signed-off-by: Francois Marier <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/920
Committed: http://gitorious.org/mahara/mahara/commit/92cfb32bd73469aa3d85d86bc3e6c6667b5491d8
Submitter: Francois Marier (<email address hidden>)
Branch: master

commit 92cfb32bd73469aa3d85d86bc3e6c6667b5491d8
Author: Melissa Draper <email address hidden>
Date: Fri Dec 9 15:05:48 2011 +1300

    Use the strftime wrapper (format_date) everywhere

    The format_date function is a wrapper for strftime, and we
    added logic to it for working around the %e parse failure
    of strftime on Windows.

    Bug #795494

    Change-Id: Ib4be53194e95e03fbb8a24da98ef61327aa3eea5
    Signed-off-by: Melissa Draper <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/1080
Committed: http://gitorious.org/mahara/mahara/commit/5227f0a0f3dca20a47b684628bd228d0d64579a2
Submitter: Hugh Davenport (<email address hidden>)
Branch: master

commit 5227f0a0f3dca20a47b684628bd228d0d64579a2
Author: Francois Marier <email address hidden>
Date: Tue Feb 28 16:46:29 2012 +1300

    Revert "Date format for windows(bug #671456)"

    While this fixed dates on Windows, it broke them on Solaris,
    OSX and BSD (bug #795494).

    This reverts commit c78df32c3d8060f6c7115eb217b03212cf9e5749.

    Change-Id: Ib74acd94ae202ec65cd6c08369e258c3c750aacc
    Signed-off-by: Francois Marier <email address hidden>