parted_server hangs if you supply an empty partition name

[Carlos Perelló Marín]

I'm installing Ubuntu's daily build for ppc (yesterday's build) and I'm editing
by hand the partitions because I want to install also MacOSX.

I'm able to edit all partitions I want but when I try to add a name to the
partition, the debian installer seems to be blocked and I'm not able to do
anything from there. The terminal still works.

If I don't try to change the partition name, it works without problems.

[Colin Watson (cjwatson)]

This mostly fixes it:

partman-partitioning (21ubuntu3) warty; urgency=low

  * Bump several more questions that are in direct response to user actions
    or that precede potential data loss to critical priority.
  * Fix number of arguments that change_name expects from PARTITION_INFO
    (Warty #1170).

 -- Colin Watson <email address hidden> Sun, 12 Sep 2004 19:56:26 +0100

It's still possible to hang parted_server by entering an empty name, which is
yet a third problem in addition to the two fixed above: the implementation of
the SET_NAME command uses fscanf(" %a[^\n]"), which never returns if you only
send whitespace. This is Debian bug #268495.

[Matt Zimmerman (mdz)]

The remainder of this bug seems minor.

Colin, if you prefer, we can track this last bit separately by importing the
Debian bug.

[Debian Bug Importer (debzilla)]

Message-ID: <email address hidden>
Date: Fri, 27 Aug 2004 22:25:14 -0400
From: Joey Hess <email address hidden>
To: Debian Bug Tracking System <email address hidden>
Subject: renaming a partition on ia64 to no name makes partman hang

--RnlQjJ0d97Da+TV1
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Package: partman
Severity: normal
Tags: d-i

I accidentially selected the partition label of my ia64 efi boot
partition in partman. The dialog to change the label for some reason did
not have the old label ("efi") in it, but I didn't notice in time, and
hit enter, which it probably understood as me asking it to set the disk
label to nothing at all. This resulted in partman hanging. Even killing
all the partman processes and restarting it didn't stop it hanging, I
had to reboot.

If it helps, I already had the efi partition set up before d-i started.

--=20
see shy jo

--RnlQjJ0d97Da+TV1
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)

iD8DBQFBL+0Kd8HHehbQuO8RAiz+AJ9HrlcjM/0d8tObVJDoiMce/+bHcgCgw/CK
aCOoM/ZTY20y6DH1SN5f/s8=
=vXGN
-----END PGP SIGNATURE-----

--RnlQjJ0d97Da+TV1--

[Debian Bug Importer (debzilla)]

Message-ID: <email address hidden>
Date: Thu, 28 Oct 2004 20:28:20 +0100
From: Colin Watson <email address hidden>
To: Joey Hess <email address hidden>
Cc: <email address hidden>
Subject: Re: renaming a partition on ia64 to no name makes partman hang

On Fri, Aug 27, 2004 at 10:25:14PM -0400, Joey Hess wrote:
> Package: partman
> Severity: normal
> Tags: d-i
>
> I accidentially selected the partition label of my ia64 efi boot
> partition in partman. The dialog to change the label for some reason did
> not have the old label ("efi") in it, but I didn't notice in time, and
> hit enter, which it probably understood as me asking it to set the disk
> label to nothing at all. This resulted in partman hanging. Even killing
> all the partman processes and restarting it didn't stop it hanging, I
> had to reboot.
>
> If it helps, I already had the efi partition set up before d-i started.

I've partly fixed this in partman-partitioning, not yet uploaded:

  * Colin Watson
    - Fix number of arguments that change_name expects from PARTITION_INFO
      (partly fixes #268495).

This should at least make sure that it's possible to change the name at
all, and that it won't leave the dialog empty to start with.

It's still possible to hang parted_server by entering an empty name,
which is a separate problem: the implementation of the SET_NAME command
uses fscanf(" %a[^\n]"), which never returns if you only send
whitespace.

Cheers,

--
Colin Watson [<email address hidden>]

[Debian Bug Importer (debzilla)]

Message-Id: <email address hidden>
Date: Thu, 28 Oct 2004 20:22:26 +0100
From: Colin Watson <email address hidden>
To: <email address hidden>
Subject: reassign 268495 to partman-partitioning

reassign 268495 partman-partitioning

[Debian Bug Importer (debzilla)]

Message-ID: <email address hidden>
Date: Thu, 6 Oct 2005 22:45:12 -0400
From: Joey Hess <email address hidden>
To: <email address hidden>
Subject: d-i tag removal

--qMm9M+Fa2AknHoGS
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

# I decided to remove the d-i tag from all packages maintained by the
# d-i team, so the list of d-i tagged bugs reduces to bugs that affect
# d-i but are not in d-i itself
tag 328992 - d-i
tag 329391 - d-i
tag 224641 - d-i
tag 213482 - d-i
tag 220282 - d-i
tag 222718 - d-i
tag 243373 - d-i
tag 274307 - d-i
tag 276726 - d-i
tag 283712 - d-i
tag 284736 - d-i
tag 292570 - d-i
tag 317062 - d-i
tag 258834 - d-i
tag 201396 - d-i
tag 220269 - d-i
tag 252121 - d-i
tag 291723 - d-i
tag 218598 - d-i
tag 218598 - d-i
tag 157888 - d-i
tag 183366 - d-i
tag 196033 - d-i
tag 200467 - d-i
tag 201252 - d-i
tag 205519 - d-i
tag 211147 - d-i
tag 212442 - d-i
tag 213834 - d-i
tag 215471 - d-i
tag 215473 - d-i
tag 216711 - d-i
tag 217503 - d-i
tag 218485 - d-i
tag 218610 - d-i
tag 218765 - d-i
tag 220483 - d-i
tag 220825 - d-i
tag 220949 - d-i
tag 221598 - d-i
tag 222308 - d-i
tag 222506 - d-i
tag 223743 - d-i
tag 224642 - d-i
tag 224904 - d-i
tag 228839 - d-i
tag 230511 - d-i
tag 230552 - d-i
tag 231137 - d-i
tag 231222 - d-i
tag 231624 - d-i
tag 231643 - d-i
tag 231766 - d-i
tag 231782 - d-i
tag 233312 - d-i
tag 233540 - d-i
tag 233957 - d-i
tag 234199 - d-i
tag 235376 - d-i
tag 235980 - d-i
tag 237397 - d-i
tag 237401 - d-i
tag 238292 - d-i
tag 238911 - d-i
tag 241434 - d-i
tag 242182 - d-i
tag 243082 - d-i
tag 243085 - d-i
tag 243565 - d-i
tag 243857 - d-i
tag 244959 - d-i
tag 244975 - d-i
tag 245136 - d-i
tag 245164 - d-i
tag 245268 - d-i
tag 247260 - d-i
tag 247593 - d-i
tag 247725 - d-i
tag 247960 - d-i
tag 248067 - d-i
tag 248163 - d-i
tag 248261 - d-i
tag 248454 - d-i
tag 248638 - d-i
tag 249305 - d-i
tag 250047 - d-i
tag 250413 - d-i
tag 250471 - d-i
tag 250823 - d-i
tag 251007 - d-i
tag 254727 - d-i
tag 257201 - d-i
tag 257211 - d-i
tag 257213 - d-i
tag 257285 - d-i
tag 258010 - d-i
tag 258085 - d-i
tag 258216 - d-i
tag 258316 - d-i
tag 258496 - d-i
tag 258545 - d-i
tag 258623 - d-i
tag 258908 - d-i
tag 259007 - d-i
tag 259264 - d-i
tag 259297 - d-i
tag 259374 - d-i
tag 259825 - d-i
tag 259869 - d-i
tag 259871 - d-i
tag 259899 - d-i
tag 261100 - d-i
tag 261200 - d-i
tag 261416 - d-i
tag 262043 - d-i
tag 262140 - d-i
tag 263075 - d-i
tag 265290 - d-i
tag 265517 - d-i
tag 266133 - d-i
tag 267441 - d-i
tag 267650 - d-i
tag 268495 - d-i
tag 268817 - d-i
tag 268950 - d-i
tag 269077 - d-i
tag 269653 - d-i
tag 269821 - d-i
tag 269972 - d-i
tag 270136 - d-i
tag 270239 - d-i
tag 270728 - d-i
tag 271065 - d-i
tag 271354 - d-i
tag 271706 - d-i
tag 272176 - d-i
tag 272411 - d-i
tag 272901 - d-i
tag 273074 - d-i
tag 273193 - d-i
tag 273982 - d-i
tag 275262 - d-i
tag 275552 - d-i
tag 276100 - d-i
tag 277901 - d-i
tag 280122 - d-i
tag 282308 - d-i
tag 287408 - d-i
tag 287409 - d-i
tag 287412 - d-i
tag 287413 - d-i
tag 290382 - d-i
tag 294814 - d-i
tag 294881 - d-i
tag 296097 - d-i
tag 299610 - d-i
tag 304565 - d-i
tag 310455 - d-i
tag 310652 - d-i
tag 313049 - d-...

[Lakin Wecker (lakin)]

Changing status to confirmed.

[Launchpad Janitor (janitor)]

This bug was fixed in the package partman-base - 128ubuntu4

---------------
partman-base (128ubuntu4) jaunty; urgency=low

  * Cope with exception options, partition flags passed to SET_FLAGS, and
    the partition name passed to SET_NAME being empty (LP: #7928).

 -- Colin Watson <email address hidden> Tue, 06 Jan 2009 17:33:28 +0000