eBuild fails to patch GRUB menu entry

[Sergey "Shnatsel" Davidoff]

eBuild was replacing stock ubuntu GRUB entry without checking if it has changed or not. I've converted it to a contextual patch with error handling, and now it fails to apply on Natty because the upstream file has changed. So, we need to make a similar patch that works for Natty.

[Sergey "Shnatsel" Davidoff (shnatsel)]

Assigning ~aroman, he seems to be the guy who made it for Jupiter.

[Eduard Gotwig (gotwig)]

isnt this fixed now?

[Eduard Gotwig (gotwig)]

ok, no its not, there is still a bug with grub, says eBuild.

[Avi Romanoff (aroman)]

Shnatsel is correct in that I was the one who created the current GRUB patch. However, I realize that it is more of a hack than a legitimate fix. I'm admittedly not a GRUB expert -- the hack I implemented for Jupiter basically works by using the nickname of the OS from the `uname` command. I believe that if you change the nickname appropriately it should function normally in Luna. That said, I would definitely consider researching an alternative system to accomplish what were trying to do and have it work reliably in the long term and with future releases. I was pressed for time with Jupiter and did not have the time.

On Jun 3, 2011, at 6:23 PM, Eduard Gotwig <email address hidden> wrote:

> ok, no its not, there is still a bug with grub, says eBuild.
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/792441
>
> Title:
> eBuild fails to patch GRUB menu entry
>
> Status in elementary OS:
> Confirmed
>
> Bug description:
> eBuild was replacing stock ubuntu GRUB entry without checking if it
> has changed or not. I've converted it to a contextual patch with error
> handling, and now it fails to apply on Natty because the upstream file
> has changed. So, we need to make a similar patch that works for Natty.

[abrsdk (abrsdk)]

hope it gets fixed soon.

[Sergey "Shnatsel" Davidoff (shnatsel)]

It's not really a vast bug, it's just a minor branding issue... there are higher-priority tasks at the moment.

[Eduard Gotwig (gotwig)]

I installed the last version of Luna (from a built iso image with eBuild). It showed Ubuntu with Linux kernel 3.0 or sth like that in the Grub boot menu

[Ivo Nunes (ivonunes)]

This bug has been fixed on latest GenOS trunk. If you want to use the fix, get my updated 10_linux.patch and check the changes I made to conf.sh.

[Sergey "Shnatsel" Davidoff (shnatsel)]

Ivo Nunes: you still will have it overwritten by upstream entries on software updates. Using eBuild is a bad idea, this legacy script is not the right way to build OS images. We're dropping eBuild in elementary OS ASAP. If you want a good build, consider using Ubuntu Customization Kit.

[Sergey "Shnatsel" Davidoff (shnatsel)]

We've ditched eBuild. FINALLY!!!

[JC Hulce (soaringsky)]

we no longer use ebuild