Add revision info to Help->About

[Till Hofmann]

Help->About doesn't give any information about the version of mixxx.
In trunk, it says "trunk" but in the mixxx ppa, About gives no information at all.

OS:
Ubuntu 10.10 Maverick
ppa:mixxx/mixxx

[Sean M. Pappalardo (pegasus-renegadetech)]

Version information automatically shows up when building a release. The code is in defs_version.h and the SConscript. Basically, if the branch being built is called release<something> it uses the version in defs_version.h. Otherwise, it uses the name of the branch. So some more logic needs to be added to accommodate the PPA build environment.

[RJ Skerry-Ryan (rryan)]

I think Till is saying that the PPA shows no version info in Help->About, despite being one of our release channels.

[RJ Skerry-Ryan (rryan)]

Confirmed in latest 1.9.2 / 1.10.0 Beta PPAs.

[RJ Skerry-Ryan (rryan)]

Actually, seems to be fixed in the beta PPA.

[Daniel Schürmann (daschuer)]

The version 1.10.0-beta1 does not show version information in the about box.
There is only "mixxx"

The 64 bit version has Version information in the Title bar. But I think the best place for it is actually the about box.

It would be nice if we could add also the bzr Revision e.g.:

mixxx 1.10.0-beta1 bzr #2880
or
mixxx 1.10.0.2880-beta1

This was tested on Ubuntu Oneiric 32 bit / Ubuntu Lucid 32 bit / Ubuntu Maverick 64 bit

[RJ Skerry-Ryan (rryan)]

I was thinking the best way to change this is to make the about box always
say the version # on which the build is based. We should introduce a
separate build constant that includes the build information such as branch
name, revision info, and so on which is only shown if the build is not a
release build.

So for example, when building Mixxx from trunk today, the about box woudl
say 1.11.0-alpha or something like that. And then since it would be a debug
build it would mention the branch name and revision.

This problem stems from the sconscript behavior where it replaces the build
version constant with a string mentioning the branch name. This is
confusing to OS-level APis that expect a version number to be
an X.Y.Z-like number as well (Debian and OSX do this).

2011/12/2 Daniel Schürmann <email address hidden>

> The version 1.10.0-beta1 does not show version information in the about
> box.
> There is only "mixxx"
>
> The 64 bit version has Version information in the Title bar. But I think
> the best place for it is actually the about box.
>
> It would be nice if we could add also the bzr Revision e.g.:
>
> mixxx 1.10.0-beta1 bzr #2880
> or
> mixxx 1.10.0.2880-beta1
>
> This was tested on Ubuntu Oneiric 32 bit / Ubuntu Lucid 32 bit / Ubuntu
> Maverick 64 bit
>
> --
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
> https://bugs.launchpad.net/bugs/789885
>
> Title:
> PPA has no version information in Help->About
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/789885/+subscriptions
>

[Daniel Schürmann (daschuer)]

The attached patch displays the bzr revision in the about box and and prints out the build flag values if > 1.

[Daniel Schürmann (daschuer)]

The attached patch distinguishes whether the bzr tree is modified or not. If modified, a "+" is added to the bzr revision.

Doing that I had strange problems with the build.h location.
The scons scripts are writing the file to lin32_build/build.h, but are reading from src/build.h

I have checked out a fresh copy lp:mixxx (without src/build.h) for cross-check. After the first build a src/build.h appears.
If you now delete src/build.h mixxx building fails.

For my feeling the lin32_build/build.h location is best because of the temporary nature of build.h.

The attached patch fixes this for me, but it may not be a common solution.

[RJ Skerry-Ryan (rryan)]

Thanks Daniel, I added your patch along with some other fixes. Now the version # is never over-written by the branch name. Instead, the branch name is provided in a separate pre-processor define BUILD_BRANCH. I output this in the syslog on startup and also in the about box.

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/5909