Leap2A export from Moodle 2.0.2 does not work

Bug #789719 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Hugh Davenport

Bug Description

via http://twitter.com/#!/midide/statuses/74085317572960256 :

"Testinstallation Moodle 2.0.2 und Mahara 1.4rc2 "Export to portfolio" mit Leap2A geht nicht - HTML Export geht - #Moodle mit Portfolio"

The export of an artefact from Moodle 2.0.2 to Mahara 1.4RC2 via Leap2A does not work. The HTML export works.

Changed in mahara:
status: New → Triaged
importance: Undecided → Medium
Changed in mahara:
milestone: none → 1.4.0
importance: Medium → High
Revision history for this message
Hugh Davenport (hugh-davenport) wrote :

I tried this out, couldn't actually get the import to fail, just an ugly error log of a bad array index.
The import still worked...
The following review contains a patch to avoid the error.
https://reviews.mahara.org/263

Kristina, if you could get any more details on what the precise error was, and how we could possibly reproduce it that would be great.

Cheers,

Hugh

Changed in mahara:
assignee: nobody → Hugh Davenport (hugh-catalyst)
status: Triaged → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/263
Committed: http://gitorious.org/mahara/mahara/commit/1aa9341abbe90b28ba59a9ebbb33b9876be5d80e
Submitter: Francois Marier (<email address hidden>)
Branch: master

commit 1aa9341abbe90b28ba59a9ebbb33b9876be5d80e
Author: Hugh Davenport <email address hidden>
Date: Tue May 31 14:12:56 2011 +1200

    Fix error log when importing from moodle via leap

    Bug #789719

    Before the data was imported, but there was an error log, and now
    the data imports but with no error log.

    Change-Id: If724d33dafc19bfe42721f6ff81b8a7dfd83b0ef
    Signed-off-by: Hugh Davenport <email address hidden>

Revision history for this message
Hugh Davenport (hugh-davenport) wrote :
Changed in mahara:
status: In Progress → Fix Committed
Changed in mahara:
status: Fix Committed → Incomplete
status: Incomplete → Fix Committed
Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

Hello Hugh,

I sent a tweet back and post any response I get.

Cheers
Kristina

Revision history for this message
Michael Ditsch (michael-ditsch) wrote :

Hello,

Case 1
Moodle:
Exporting content from Forum: News and Announcements
Exporting content to Mahara ePortfolio
Summary of your export
Selected export format HTML
Please confirm this export
Continue to your portfolio
Mahara shows:
Home / incoming (with exported HTML file)

Case 2
Moodle
Exporting content from Forum: News and Announcements
Exporting content to Mahara ePortfolio
Summary of your export
Selected export format Leap2A portfolio format
Please confirm this export
Continue to your portfolio
Mahara shows:
Dashboard (no file in Home / incoming)

/var/log/apache2/error.log
[Wed Jun 01 08:12:39 2011] [error] [client 127.0.0.1] [WAR] ab (import/leap/lib.php:1075) Undefined offset: 0
[Wed Jun 01 08:12:39 2011] [error] [client 127.0.0.1] Call stack (most recent first):
[Wed Jun 01 08:12:39 2011] [error] [client 127.0.0.1] * log_message("Undefined offset: 0", 8, true, true, "/var/www/mahara/import/leap/lib.php", 1075) at /var/www/mahara/lib/errors.php:446
[Wed Jun 01 08:12:39 2011] [error] [client 127.0.0.1] * error(8, "Undefined offset: 0", "/var/www/mahara/import/leap/lib.php", 1075, array(size 3)) at /var/www/mahara/import/leap/lib.php:1075
[Wed Jun 01 08:12:39 2011] [error] [client 127.0.0.1] * PluginImportLeap->get_entry_by_id("http://www.mydomain.com/user/view.php?id=148") at /var/www/mahara/import/leap/lib.php:239
[Wed Jun 01 08:12:39 2011] [error] [client 127.0.0.1] * PluginImportLeap->create_strategy_listing() at /var/www/mahara/import/leap/lib.php:135
[Wed Jun 01 08:12:39 2011] [error] [client 127.0.0.1] * PluginImportLeap->process() at /var/www/mahara/api/xmlrpc/lib.php:473
[Wed Jun 01 08:12:39 2011] [error] [client 127.0.0.1] * send_content_ready("cde8974441442d1ba0bbf199b618fa561025077c", "user1", "leap2a", array(size 4), 1) at Unknown:0
[Wed Jun 01 08:12:39 2011] [error] [client 127.0.0.1] * call_user_func_array("send_content_ready", array(size 5)) at /var/www/mahara/api/xmlrpc/lib.php:122
[Wed Jun 01 08:12:39 2011] [error] [client 127.0.0.1] * api_dummy_method("portfolio/mahara/lib.php/send_content_ready", array(size 5), "send_content_ready") at Unknown:0
[Wed Jun 01 08:12:39 2011] [error] [client 127.0.0.1] * xmlrpc_server_call_method(resource(#41), "<?xml version="1.0" encoding="utf-8"?>
[Wed Jun 01 08:12:39 2011] [error] [client 127.0.0.1] <methodCall...", "send_content_ready", array(size 1)) at /var/www/mahara/api/xmlrpc/dispatcher.php:191
[Wed Jun 01 08:12:39 2011] [error] [client 127.0.0.1] * Dispatcher->__construct("<?xml version="1.0" encoding="utf-8"?>
[Wed Jun 01 08:12:39 2011] [error] [client 127.0.0.1] <methodCall...", true, true) at /var/www/mahara/api/xmlrpc/server.php:142
[Wed Jun 01 08:15:10 2011] [error] [client 127.0.0.1] [DBG] 6b (auth/user.php:1075) Destroying user with un-committed changes, referer: http://www.mydomain.com/portfolio/add.php

Regards
Michael

Revision history for this message
Hugh Davenport (hugh-davenport) wrote :
Download full text (3.5 KiB)

Hi Michael,

The fix that was merged with this bug will fix that error log you see.

With your leap imports, they don't go into the files area, instead they
go to where they are meant to go :)

For example, when exporting from a forum in moodle, the forum will
become a new journal (Content->Journal). I believe you will find it
there. I will mark this bug as fixed, and if you still have trouble, you
can reopen this bug, or open a new one.

Cheers,

Hugh

 status fixcommitted

On 01/06/11 18:37, Michael Ditsch wrote:
> Hello,
>
> Case 1
> Moodle:
> Exporting content from Forum: News and Announcements
> Exporting content to Mahara ePortfolio
> Summary of your export
> Selected export format HTML
> Please confirm this export
> Continue to your portfolio
> Mahara shows:
> Home / incoming (with exported HTML file)
>
> Case 2
> Moodle
> Exporting content from Forum: News and Announcements
> Exporting content to Mahara ePortfolio
> Summary of your export
> Selected export format Leap2A portfolio format
> Please confirm this export
> Continue to your portfolio
> Mahara shows:
> Dashboard (no file in Home / incoming)
>
> /var/log/apache2/error.log
> [Wed Jun 01 08:12:39 2011] [error] [client 127.0.0.1] [WAR] ab (import/leap/lib.php:1075) Undefined offset: 0
> [Wed Jun 01 08:12:39 2011] [error] [client 127.0.0.1] Call stack (most recent first):
> [Wed Jun 01 08:12:39 2011] [error] [client 127.0.0.1] * log_message("Undefined offset: 0", 8, true, true, "/var/www/mahara/import/leap/lib.php", 1075) at /var/www/mahara/lib/errors.php:446
> [Wed Jun 01 08:12:39 2011] [error] [client 127.0.0.1] * error(8, "Undefined offset: 0", "/var/www/mahara/import/leap/lib.php", 1075, array(size 3)) at /var/www/mahara/import/leap/lib.php:1075
> [Wed Jun 01 08:12:39 2011] [error] [client 127.0.0.1] * PluginImportLeap->get_entry_by_id("http://www.mydomain.com/user/view.php?id=148") at /var/www/mahara/import/leap/lib.php:239
> [Wed Jun 01 08:12:39 2011] [error] [client 127.0.0.1] * PluginImportLeap->create_strategy_listing() at /var/www/mahara/import/leap/lib.php:135
> [Wed Jun 01 08:12:39 2011] [error] [client 127.0.0.1] * PluginImportLeap->process() at /var/www/mahara/api/xmlrpc/lib.php:473
> [Wed Jun 01 08:12:39 2011] [error] [client 127.0.0.1] * send_content_ready("cde8974441442d1ba0bbf199b618fa561025077c", "user1", "leap2a", array(size 4), 1) at Unknown:0
> [Wed Jun 01 08:12:39 2011] [error] [client 127.0.0.1] * call_user_func_array("send_content_ready", array(size 5)) at /var/www/mahara/api/xmlrpc/lib.php:122
> [Wed Jun 01 08:12:39 2011] [error] [client 127.0.0.1] * api_dummy_method("portfolio/mahara/lib.php/send_content_ready", array(size 5), "send_content_ready") at Unknown:0
> [Wed Jun 01 08:12:39 2011] [error] [client 127.0.0.1] * xmlrpc_server_call_method(resource(#41), "<?xml version="1.0" encoding="utf-8"?>
> [Wed Jun 01 08:12:39 2011] [error] [client 127.0.0.1] <methodCall...", "send_content_ready", array(size 1)) at /var/www/mahara/api/xmlrpc/dispatcher.php:191
> [Wed Jun 01 08:12:39 2011] [error] [client 127.0.0.1] * Dispatcher->__construct("<?xml version="1.0" encoding="utf-8"?>
> [Wed Jun 01 08:12:39 2011] [error] [client 127.0.0.1] <m...

Read more...

Revision history for this message
Michael Ditsch (michael-ditsch) wrote :

Hi Hugh,

ok, I understand, thanks!
IMHO a user could be puzzled ending up at Mahara dashboard without feedback about successful export/import.

Thanks for Mahara. You're doing a great job!

Regards
Michael

Revision history for this message
Hugh Davenport (hugh-davenport) wrote :

Hi Michael,

I think your right. When I first tried doing a leap export/import from moodle I did get
a bit confused, but then noticed it was in the journals area.

I think it would be worthwhile you opening a new bug along the lines of the comments below.

After you create the bug, just paste the link in this bug.

Cheers,

Hugh

Leap import from moodle doesn't give confirmation

When I import a forum post from moodle using Leap, I would expect it to give some
sort of confirmation that it was imported correctly, and my browser gets delivered to
the journals page (where the data was imported).

Instead, there is no confirmation, and my browser gets taken only to the dashboard.
I find this a but confusing, and think it would be a good idea to give some confirmation
and link to the imported location.

This bug was made after discussion on bug 789719
https://bugs.launchpad.net/mahara/+bug/789719

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

The new bug report regarding the import message is at https://bugs.launchpad.net/bugs/793371

Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.