Passing functional tests leaving test data around

[Rick Harris]

Looks like two functional tests that are passing are still leaving test data around in the /tmp directory.

e.g.

Ran 127 tests in 27.366s

OK
rick@maverick:~/openstack/glance/lp779311$ ls /tmp
test.95547 test.99353

We should figure out which tests are doing this, and ensure that the tearDown does a proper rmtree on those dirs.

[Jay Pipes (jaypipes)]

So.... any test that does not call stop_servers() at the end of the test case will leave data around. This was on purpose. I wanted the test directory to persist if there was an exception/assert during a test case.

From looking through the code, looks like tests.functional.TestCurlApi.test_queued_process_flow() and test_filtered_images() are the culprits. I'll get the fixes proposed shortly.

-jay

[Brian Waldon (bcwaldon)]

I love having Jay around to clean up my mistakes :)

[Dan Prince (dan-prince)]

Yep. We are all human here. We'll get some of his too.

Dan

-----Original Message-----
From: "Brian Waldon" <email address hidden>
Sent: Friday, May 27, 2011 10:51am
To: <email address hidden>
Subject: [Bug 788920] Re: Passing functional tests leaving test data around

I love having Jay around to clean up my mistakes :)

--
You received this bug notification because you are subscribed to Glance.
https://bugs.launchpad.net/bugs/788920

Title:
  Passing functional tests leaving test data around

Status in OpenStack Image Registry and Delivery Service (Glance):
  In Progress

Bug description:
  Looks like two functional tests that are passing are still leaving
  test data around in the /tmp directory.

  e.g.

  Ran 127 tests in 27.366s

  OK
  rick@maverick:~/openstack/glance/lp779311$ ls /tmp
  test.95547 test.99353

  We should figure out which tests are doing this, and ensure that the
  tearDown does a proper rmtree on those dirs.

[Jay Pipes (jaypipes)]

Ha! It was my mistake, too :)

[Joshua McKenty (joshua-mckenty)]

Who you calling human? I'm fairly certain Termie is a cyborg.

Joshua McKenty
Piston Cloud Computing, Inc.
[phone]
<email address hidden>

On 2011-05-27, at 8:05 AM, Dan Prince wrote:

> Yep. We are all human here. We'll get some of his too.
>
> Dan
>
> -----Original Message-----
> From: "Brian Waldon" <email address hidden>
> Sent: Friday, May 27, 2011 10:51am
> To: <email address hidden>
> Subject: [Bug 788920] Re: Passing functional tests leaving test data around
>
> I love having Jay around to clean up my mistakes :)
>
> --
> You received this bug notification because you are subscribed to Glance.
> https://bugs.launchpad.net/bugs/788920
>
> Title:
> Passing functional tests leaving test data around
>
> Status in OpenStack Image Registry and Delivery Service (Glance):
> In Progress
>
> Bug description:
> Looks like two functional tests that are passing are still leaving
> test data around in the /tmp directory.
>
> e.g.
>
> Ran 127 tests in 27.366s
>
> OK
> rick@maverick:~/openstack/glance/lp779311$ ls /tmp
> test.95547 test.99353
>
> We should figure out which tests are doing this, and ensure that the
> tearDown does a proper rmtree on those dirs.
>
> --
> You received this bug notification because you are a member of Glance
> Bug Team, which is subscribed to Glance.
> https://bugs.launchpad.net/bugs/788920
>
> Title:
> Passing functional tests leaving test data around
>
> Status in OpenStack Image Registry and Delivery Service (Glance):
> In Progress
>
> Bug description:
> Looks like two functional tests that are passing are still leaving
> test data around in the /tmp directory.
>
> e.g.
>
> Ran 127 tests in 27.366s
>
> OK
> rick@maverick:~/openstack/glance/lp779311$ ls /tmp
> test.95547 test.99353
>
> We should figure out which tests are doing this, and ensure that the
> tearDown does a proper rmtree on those dirs.