Groupsdialog.py coding error

[Russell Richardson]

On the latest pull of the dev branch I noticed that there is an error in the file groupsdialog.py

While listing the imports of the translations (line 24) you have import listed twice, this causes the program to not open at all. I was able to fix it by removing one of the "import" at the end. I would have submitted the change in the file, but I didn't know how to... (I'm new to using LaunchPad and bzr), so I have added my copy of "groupsdialog.py", I also have checked the box "This attachment is a patch", I don't know if that is the right option, but it sounds like it couldn't hurt.

Thanks, I'm looking forward to seeing this project grow! I don't like editing all of those .desktop files
Hopefully I will be able to help, I have been trying to learn Python :)

Edit: Ok, so apparently the attachment isn't really a patch, so I have unchecked that option.

[Russell Richardson (russjr08)]

Ok, I found out to have bzr give me a patch file! I am uploading the patch file as an attachment now :)

[Laudeci Oliveira (laudeci)]

Thank you for your report and patch, that problem was fixed but not merged.

Keep sending patches :)

---------------------------------------------------------------------------------------------------------------------------
Laudeci Oliveira
Official Ubuntu Member
Red Hat Certified Technician
Tecnólogo em Sistema de Informação

2011/5/20 Russell Richardson <email address hidden>

> Ok, I found out to have bzr give me a patch file! I am uploading the
> patch file as an attachment now :)
>
>
> ** Patch added: "Patch for groupsdialog.py"
>
> https://bugs.launchpad.net/unity-launcher-editor/+bug/785809/+attachment/2136446/+files/groupsdialog.patch
>
> --
> You received this bug notification because you are the registrant for
> unity-launcher-editor.
> https://bugs.launchpad.net/bugs/785809
>
> Title:
> Groupsdialog.py coding error
>

[Russell Richardson (russjr08)]

Thanks Laudeci, but I have to ask, is there an official way to submit patches? Or do I just open a new bug report for each patch I submit? I think the official way has something to do with bzr commit?

[Laudeci Oliveira (laudeci)]

I will check it and will tell you how to do ok?
;)
---------------------------------------------------------------------------------------------------------------------------
Laudeci Oliveira
Official Ubuntu Member
Red Hat Certified Technician
Tecnólogo em Sistema de Informação

2011/5/20 Russell Richardson <email address hidden>

> Thanks Laudeci, but I have to ask, is there an official way to submit
> patches? Or do I just open a new bug report for each patch I submit? I
> think the official way has something to do with bzr commit?
>
> ** Changed in: unity-launcher-editor
> Status: New => Fix Released
>
> --
> You received this bug notification because you are the registrant for
> unity-launcher-editor.
> https://bugs.launchpad.net/bugs/785809
>
> Title:
> Groupsdialog.py coding error
>

[Russell Richardson (russjr08)]

Ok, thanks :)